From: Chuanhong Guo <gch981213@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] dt-binding: spi: add bindings for spi-ar934x
Date: Sat, 8 Feb 2020 17:36:57 +0800 [thread overview]
Message-ID: <CAJsYDVJ3RfMh9MrMGsS=9=XayJjkatwnVa6DRjf6KmYp8JS9SQ@mail.gmail.com> (raw)
In-Reply-To: <7f53a397-0237-4c68-e284-d92adf19c368@gmail.com>
On Sat, Feb 8, 2020 at 7:54 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 2/6/20 9:55 PM, Chuanhong Guo wrote:
> > It's caused by "clocks = <&pll ATH79_CLK_AHB>" where ATH79_CLK_AHB
> > isn't defined without a include of dt-bindings/clock/ath79-clk.h
> > I'll replace this with a bogus "clocks = <&spi_clock>" instead in v3.
>
> You can include ath79-clk.h in your example, see for instance
> Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
Oh. But I've already sent v3 out yesterday :(
I think this is just cosmetic changes and doesn't make much difference
so I'd like to keep v3 as-is now and if there are other comments for
me to send a v4 I'll change this one as well.
Regards,
Chuanhong Guo
prev parent reply other threads:[~2020-02-08 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 15:06 [PATCH v2 0/2] spi: add driver for ar934x spi controller Chuanhong Guo
[not found] ` <20200206150626.708649-1-gch981213-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-06 15:06 ` [PATCH v2 1/2] " Chuanhong Guo
2020-02-06 15:06 ` [PATCH v2 2/2] dt-binding: spi: add bindings for spi-ar934x Chuanhong Guo
[not found] ` <20200206150626.708649-3-gch981213-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-06 20:55 ` Rob Herring
2020-02-07 5:55 ` Chuanhong Guo
[not found] ` <CAJsYDVKXvAkQawwayX8JVrjvEKPuTyQXE8rw=BRiyVROKrdWrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-07 23:54 ` Florian Fainelli
2020-02-08 9:36 ` Chuanhong Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJsYDVJ3RfMh9MrMGsS=9=XayJjkatwnVa6DRjf6KmYp8JS9SQ@mail.gmail.com' \
--to=gch981213@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).