From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF87AC4338F for ; Mon, 23 Aug 2021 16:31:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C11D060F91 for ; Mon, 23 Aug 2021 16:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229819AbhHWQbn (ORCPT ); Mon, 23 Aug 2021 12:31:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbhHWQbn (ORCPT ); Mon, 23 Aug 2021 12:31:43 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43625C061760 for ; Mon, 23 Aug 2021 09:31:00 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id r19so27038069eds.13 for ; Mon, 23 Aug 2021 09:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3UJqarI9sJh/SEzyJatryVnyGRWftRgbiqbTe8APv5I=; b=FsrV/vjP9FwD6+gGUwE7brUSey8SYKVwpEPyJQ0ZE91a3dyKjLFv4giwo7QDacAyFw egWdkhxhj9NUwi0HHZgK6yGJwJqJ9HDb4qRQTaVMnHGO8gG3ZeKZZnYYlrfNm693Fy0Y oQ7hh6DOM1oB/BYhyFoBA7veyoZ+c37euu8VuV+OZ6P//3RXOx3M7EEGpEYyTjgd2uYE MuUNLxBrhnc9SLBdXN+ef9CFeC33EpLfc4dt8uuN0PDzFbh3LbEJ8k/+9p+0HmJfgQdQ CnTT/UROf8/CFKl03Gou5JKZcVBU8MPgFGcCZmh4qpB9Vjhu1UYXY1utX6FUrmozWZgV tXbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3UJqarI9sJh/SEzyJatryVnyGRWftRgbiqbTe8APv5I=; b=EdHObV7CrLGCzrAwtGdx5NU6ya4E7WPkRUvLSG0ZHP8YY4K2hgu2KYntC5/+0eLWq/ gItxE1AJ2gZ9pnYGADaOLQt7ItY39e+X9kMG89TSOqHovIGm9pdM9XHlet8AbRlvDyNE yCvjWPN7EnVR7uSCqjmag0X8+UY+j/1+iYnMGDE77fwAvxD+XfjTXYYeTcV24iP4c0Q1 WTujMFv9AmIVtGaH2OVnmQaMbAQ8shL4PaWRAkiwqyzxewQfEOFkhdWY0Fn693GxT5Kr 65Iqhsf7qEzFvAT4J37wn8lbOpUQH3p/NNr1au4U6zB5IG6nCyloe4+6erjszz4RXU9A Zc2g== X-Gm-Message-State: AOAM530Vly8W4sX8PUXxaUStyhZJ90Yb7S3SPu3X6cjJuDZP5RLVPwWG hEYTFLMcilZFp6X3AVU6tlOY0RxWovFIIsJKDBt2Xw== X-Google-Smtp-Source: ABdhPJwCkyepKnYLjaro8KpvCFMhXySyvI2odnfjv7k323shjYJULMJoXC1kqfT5uu34xj4dmG7LvzhRZ/0V8efQvKs= X-Received: by 2002:a05:6402:5208:: with SMTP id s8mr38656411edd.222.1629736258724; Mon, 23 Aug 2021 09:30:58 -0700 (PDT) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-2-brad@pensando.io> In-Reply-To: From: Brad Larson Date: Mon, 23 Aug 2021 09:30:47 -0700 Message-ID: Subject: Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control To: Geert Uytterhoeven Cc: Andy Shevchenko , linux-arm Mailing List , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hi Geert, On Mon, Aug 23, 2021 at 12:50 AM Geert Uytterhoeven wrote: > > Hi Brad, > > On Mon, Aug 23, 2021 at 3:14 AM Brad Larson wrote: > > On Mon, Mar 29, 2021 at 3:40 AM Andy Shevchenko [...] > > Regarding the above module question and Kconfig definition, since I > > first looked at this and reviewed the comments I realized I should be > > using builtin. The file gpio/Kconfig is currently this > > > > config GPIO_ELBA_SPICS > > def_bool y > > depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST > > That means the driver will default to yes by merely enabling > COMPILE_TEST, which is a no-go. > > config GPIO_ELBA_SPICS > bool "one-line summary" > depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST > default y if ARCH_PENSANDO_ELBA_SOC Thanks Geert, changed to this --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -241,8 +241,9 @@ config GPIO_EIC_SPRD Say yes here to support Spreadtrum EIC device. config GPIO_ELBA_SPICS + bool "Pensando Elba SoC SPI Chip Select as GPIO support" + depends on ARCH_PENSANDO_ELBA_SOC def_bool y - depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST Regards, Brad