From: Linus Walleij <linus.walleij@linaro.org>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: "pratyush.anand@st.com" <pratyush.anand@st.com>,
"rajeev-dlh.kumar@st.com" <rajeev-dlh.kumar@st.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"bhupesh.sharma@st.com" <bhupesh.sharma@st.com>,
"shiraz.hashim@st.com" <shiraz.hashim@st.com>,
"armando.visconti@st.com" <armando.visconti@st.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"spi-devel-general@lists.sourceforge.net"
<spi-devel-general@lists.sourceforge.net>,
"vipin.kumar@st.com" <vipin.kumar@st.com>,
"Koul, Vinod" <vinod.koul@intel.com>,
"Amit.VIRDI@st.com" <Amit.VIRDI@st.com>,
"vipulkumar.samar@st.com" <vipulkumar.samar@st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
"deepak.sikri@st.com" <deepak.sikri@st.com>,
"bhavna.yadav@st.com" <bhavna.yadav@st.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.o
Subject: Re: [PATCH V2 6/6] spi/spi-pl022: Request/free DMA channels as and when required.
Date: Thu, 11 Aug 2011 16:48:54 +0200 [thread overview]
Message-ID: <CAKnu2MptC8HWCNo6W+X9rawn6MCwAe3DB3B5UcHD1tCD9tA2cg@mail.gmail.com> (raw)
In-Reply-To: <CABb+yY0G_OeVgQs4ySVMQBcBh2q=nUhj+U+=tZG751WT9qRYuA@mail.gmail.com>
2011/8/11 Jassi Brar <jassisinghbrar@gmail.com>:
> Do you have any reason for using device pointer and strings, other
> than just "because clock and regulator use them" ??
Basically no.
But I think these frameworks are very workable and proven
to work in practice. So I like them.
When setting up the platform the coder would to be aware
that there are totally orthogonal concepts, which IMO
makes things complicated.
>>> Do you propose to implement a string parser in the core ?!
>>
>> Yes, the clock and regulator framework already does that.
>> But it is only used when you cannot pass in a struct device *
>> directly, like from device tree.
>
> Dude, I have utter disrespect for using strings in a case such as
> expressing requirements.
It's mainly a strcmp(), and it's only comparing to the
well-established namespace that all devices have anyway,
due to the way the device model is done.
Basically when binding clocks or regulators it's:
struct device *dev;
strcmp(map_string, dev_name(dev));
By this time struct device exist of course, since
it's the device driver calling to get its clock/regulator.
dev_name() comes from <linux/device.h> and basically
takes the kobject name or an optional initilizer name
for the device. So the names are pretty static, you don't
need to parse them, just compare.
> I have already explained how we can easily and in a _better_ way
> do without them (again see my last reply to Vindo's setup).
> Tell me 1 reason why using strings, in this case, would be better ?
I have no other reasons than the above.
People like Russell (clkdevice) and Liam Girdwood (regulator)
who I know are smarter than me and have worked with
these subsystems for years choose that model, so I trust
their judgement.
Thanks,
Linus Walleij
next prev parent reply other threads:[~2011-08-11 14:48 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 8:50 [PATCH V2 0/6] spi/spi-pl022 fixes Viresh Kumar
2011-08-10 8:50 ` [PATCH V2 1/6] spi/spi-pl022: Resolve formatting issues Viresh Kumar
2011-09-20 17:17 ` Grant Likely
[not found] ` <cover.1312965741.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2011-08-10 8:50 ` [PATCH V2 2/6] spi/spi-pl022: Use GFP_ATOMIC for allocation from tasklet Viresh Kumar
2011-08-10 8:50 ` [PATCH V2 3/6] spi/spi-pl022: Don't allocate more sg than required Viresh Kumar
2011-08-10 8:54 ` Russell King - ARM Linux
2011-08-10 9:05 ` viresh kumar
2011-08-10 11:42 ` Sergei Shtylyov
2011-08-10 11:46 ` viresh kumar
2011-08-10 8:50 ` [PATCH V2 4/6] spi/spi-pl022: calculate_effective_freq() must set rate <= requested rate Viresh Kumar
2011-08-10 8:50 ` [PATCH V2 5/6] spi/spi-pl022: Call pl022_dma_remove(pl022) only if enable_dma is true Viresh Kumar
2011-08-10 8:50 ` [PATCH V2 6/6] spi/spi-pl022: Request/free DMA channels as and when required Viresh Kumar
2011-08-10 9:00 ` Russell King - ARM Linux
2011-08-10 9:29 ` viresh kumar
2011-08-10 10:01 ` Koul, Vinod
[not found] ` <438BB0150E931F4B9CE701519A4463010871804A15-qq4HA3s+46oFyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-08-10 10:14 ` viresh kumar
2011-08-10 10:32 ` Russell King - ARM Linux
2011-08-10 16:53 ` Koul, Vinod
2011-08-10 10:29 ` Russell King - ARM Linux
2011-08-10 10:31 ` Jassi Brar
2011-08-10 10:40 ` Russell King - ARM Linux
2011-08-10 11:24 ` Jassi Brar
2011-08-10 11:54 ` Linus Walleij
2011-08-10 13:16 ` Jassi Brar
2011-08-10 20:58 ` Vinod Koul
2011-08-10 18:59 ` Jassi Brar
2011-08-16 11:55 ` Koul, Vinod
2011-08-16 14:51 ` Jassi Brar
2011-08-19 13:49 ` Koul, Vinod
2011-08-11 12:55 ` Linus Walleij
2011-08-11 14:22 ` Jassi Brar
2011-08-11 14:48 ` Linus Walleij [this message]
[not found] ` <CAKnu2MptC8HWCNo6W+X9rawn6MCwAe3DB3B5UcHD1tCD9tA2cg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-11 17:05 ` Jassi Brar
2011-08-11 22:35 ` Koul, Vinod
2011-08-10 10:09 ` Jassi Brar
[not found] ` <CABb+yY0Qvuhrn+FUhWDHMwUjv=nR4MOfLeDfTzG17HXEuu2pmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-10 10:30 ` Russell King - ARM Linux
2011-08-10 10:48 ` Jassi Brar
2011-08-10 11:42 ` [PATCH V3 3/6] spi/spi-pl022: Don't allocate more sg than required Viresh Kumar
2011-09-01 10:04 ` [PATCH V2 0/6] spi/spi-pl022 fixes Viresh Kumar
2011-09-01 10:56 ` Linus Walleij
[not found] ` <CACRpkdYeq9in+U_tyvb=yVuX2t5TnkUSsO+BozUGVJwZVh+4Ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-20 11:16 ` Viresh Kumar
2011-09-20 17:23 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKnu2MptC8HWCNo6W+X9rawn6MCwAe3DB3B5UcHD1tCD9tA2cg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Amit.VIRDI@st.com \
--cc=armando.visconti@st.com \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=dan.j.williams@intel.com \
--cc=deepak.sikri@st.com \
--cc=grant.likely@secretlab.ca \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.o \
--cc=linux@arm.linux.org.uk \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=shiraz.hashim@st.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=vinod.koul@intel.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).