From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Eremin-Solenikov Subject: Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo Date: Fri, 14 Nov 2014 19:30:22 +0400 Message-ID: References: <1414454528-24240-1-git-send-email-dbaryshkov@gmail.com> <1414454528-24240-2-git-send-email-dbaryshkov@gmail.com> <20141105202405.GJ8509@sirena.org.uk> <20141114151000.GC3815@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Linus Walleij , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , Linux Input , "linux-leds@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "alsa-devel@alsa-project.org" , Andrea Adami , Russell King , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Alexandre Courbot , Dmitry Torokhov , Bryan Wu , Richard Purdie , Samuel Ortiz , Lee Jones To: Mark Brown Return-path: In-Reply-To: <20141114151000.GC3815@sirena.org.uk> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org 2014-11-14 18:10 GMT+03:00 Mark Brown : > On Fri, Nov 14, 2014 at 04:47:00PM +0400, Dmitry Eremin-Solenikov wrote: > >> I'm actually looking at the regulator interface. Since this DAC serves mostly >> like a (semi-)constant voltage interface, would it be rather logical to use >> regulator subsystem to drive it? > > Possibly... it's mostly a function of what the consumers of the > functionality look like - if that code looks weird calling into the > regulator API then it's bad, if that code looks OK it's fine. I haven't > looked at the hardware at all so don't have strong feelings either way > so long as the result looks tasteful. The DAC is used in backlight driver (control brightness) and in ASoC machine driver (master joined volume). -- With best wishes Dmitry