Linux-SPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH V2 4/4] dt-bindings: lpspi: New property in document DT bindings for LPSPI
@ 2020-07-27  3:15 Clark Wang
  2020-07-31 17:38 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Clark Wang @ 2020-07-27  3:15 UTC (permalink / raw)
  To: broonie, robh+dt, Anson.Huang; +Cc: linux-spi, devicetree, linux-kernel

Add "fsl,spi-only-use-cs1-sel" to fit i.MX8DXL-EVK.
Spi common code does not support use of CS signals discontinuously.
It only uses CS1 without using CS0. So, add this property to re-config
chipselect value.

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
---
Changes:
V2:
 - New patch added in the v2 patchset.
---
 Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
index 143b94a1883a..22882e769e26 100644
--- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
@@ -34,6 +34,12 @@ properties:
       - const: per
       - const: ipg
 
+  fsl,spi-only-use-cs1-sel:
+    description:
+      spi common code does not support use of CS signals discontinuously.
+      i.MX8DXL-EVK board only uses CS1 without using CS0. Therefore, add
+      this property to re-config the chipselect value in the LPSPI driver.
+
 required:
   - compatible
   - reg
@@ -57,4 +63,5 @@ examples:
                  <&clks IMX7ULP_CLK_DUMMY>;
         clock-names = "per", "ipg";
         spi-slave;
+        fsl,spi-only-use-cs1-sel;
     };
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH V2 4/4] dt-bindings: lpspi: New property in document DT bindings for LPSPI
  2020-07-27  3:15 [PATCH V2 4/4] dt-bindings: lpspi: New property in document DT bindings for LPSPI Clark Wang
@ 2020-07-31 17:38 ` Rob Herring
  2020-08-07 14:51   ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2020-07-31 17:38 UTC (permalink / raw)
  To: Clark Wang; +Cc: Mark Brown, Anson Huang, linux-spi, devicetree, linux-kernel

On Sun, Jul 26, 2020 at 9:15 PM Clark Wang <xiaoning.wang@nxp.com> wrote:
>
> Add "fsl,spi-only-use-cs1-sel" to fit i.MX8DXL-EVK.
> Spi common code does not support use of CS signals discontinuously.
> It only uses CS1 without using CS0. So, add this property to re-config
> chipselect value.
>
> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> ---
> Changes:
> V2:
>  - New patch added in the v2 patchset.
> ---
>  Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
> index 143b94a1883a..22882e769e26 100644
> --- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
> @@ -34,6 +34,12 @@ properties:
>        - const: per
>        - const: ipg
>
> +  fsl,spi-only-use-cs1-sel:
> +    description:
> +      spi common code does not support use of CS signals discontinuously.
> +      i.MX8DXL-EVK board only uses CS1 without using CS0. Therefore, add
> +      this property to re-config the chipselect value in the LPSPI driver.

This breaks linux-next and you didn't test with 'make dt_binding_check':

/builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml:
properties:fsl,spi-only-use-cs1-sel: {'description': 'spi common code
does not support use of CS signals discontinuously. i.MX8DXL-EVK board
only uses CS1 without using CS0. Therefore, add this property to
re-config the chipselect value in the LPSPI driver.'} is not valid
under any of the given schemas (Possible causes of the failure):
 /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml:
properties:fsl,spi-only-use-cs1-sel: 'not' is a required property

The problem is you need a type definition for a vendor specific
property. In this case 'type: boolean'.

Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH V2 4/4] dt-bindings: lpspi: New property in document DT bindings for LPSPI
  2020-07-31 17:38 ` Rob Herring
@ 2020-08-07 14:51   ` Rob Herring
  0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-08-07 14:51 UTC (permalink / raw)
  To: Clark Wang; +Cc: Mark Brown, Anson Huang, linux-spi, devicetree, linux-kernel

On Fri, Jul 31, 2020 at 11:38 AM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Sun, Jul 26, 2020 at 9:15 PM Clark Wang <xiaoning.wang@nxp.com> wrote:
> >
> > Add "fsl,spi-only-use-cs1-sel" to fit i.MX8DXL-EVK.
> > Spi common code does not support use of CS signals discontinuously.
> > It only uses CS1 without using CS0. So, add this property to re-config
> > chipselect value.
> >
> > Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> > ---
> > Changes:
> > V2:
> >  - New patch added in the v2 patchset.
> > ---
> >  Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
> > index 143b94a1883a..22882e769e26 100644
> > --- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
> > @@ -34,6 +34,12 @@ properties:
> >        - const: per
> >        - const: ipg
> >
> > +  fsl,spi-only-use-cs1-sel:
> > +    description:
> > +      spi common code does not support use of CS signals discontinuously.
> > +      i.MX8DXL-EVK board only uses CS1 without using CS0. Therefore, add
> > +      this property to re-config the chipselect value in the LPSPI driver.
>
> This breaks linux-next and you didn't test with 'make dt_binding_check':
>
> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml:
> properties:fsl,spi-only-use-cs1-sel: {'description': 'spi common code
> does not support use of CS signals discontinuously. i.MX8DXL-EVK board
> only uses CS1 without using CS0. Therefore, add this property to
> re-config the chipselect value in the LPSPI driver.'} is not valid
> under any of the given schemas (Possible causes of the failure):
>  /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml:
> properties:fsl,spi-only-use-cs1-sel: 'not' is a required property
>
> The problem is you need a type definition for a vendor specific
> property. In this case 'type: boolean'.

Ping! And now Linus' tree is broken. If you can't be bothered to fix
this, perhaps it should be reverted.

Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27  3:15 [PATCH V2 4/4] dt-bindings: lpspi: New property in document DT bindings for LPSPI Clark Wang
2020-07-31 17:38 ` Rob Herring
2020-08-07 14:51   ` Rob Herring

Linux-SPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spi/0 linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ https://lore.kernel.org/linux-spi \
		linux-spi@vger.kernel.org
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git