From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F2B7C4338F for ; Mon, 23 Aug 2021 20:11:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05410613D0 for ; Mon, 23 Aug 2021 20:11:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232016AbhHWUMX (ORCPT ); Mon, 23 Aug 2021 16:12:23 -0400 Received: from mail-ua1-f48.google.com ([209.85.222.48]:41889 "EHLO mail-ua1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231716AbhHWUMW (ORCPT ); Mon, 23 Aug 2021 16:12:22 -0400 Received: by mail-ua1-f48.google.com with SMTP id 75so8628582uav.8; Mon, 23 Aug 2021 13:11:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AUpBckzMvXVbMxlgD0BPIwC+4lv7J+IVl66jvYDUuHo=; b=b/b73x2JZ4KjhsEwbh5qDWlakyitUjKztvAIJ2rAAS4I4bNKH+9KGyptdIZoxFWiDs xQ/JCbD6F/C+01FIMrGXBChGCGpFU8WOaTevRNKmehs/N1R1QuDMmDQvQqtFoAwFSQcS nHwi55DtxdZh7Ti9Vvjqwh4TOGEq2ZccpGCkDiiZkl34QyVdGaOzdAB3dNugpW6ItK2A i8FNJobWm6h2P6tNbJEbh6zdm7bko7rp/n+06ZbOqLaDwOEihCYapfnXO/SnHl4Fo8Yz KxTOcqZkMrBKZWH06K0/wurAt6tuwMu9t36vhdnGK3T8mYFytmwnNVfALqScEc4hMqkC Ydjw== X-Gm-Message-State: AOAM530bdWMhqCjhvhTk+pTYI9PsLqsxz4jvhMEzCNeWqOd3888NK55r UarhKBuKCqKEwMvXHvR/MjVBdfIeBkGr1IokwoA= X-Google-Smtp-Source: ABdhPJwDCxee7jV2n8a1Svw2CcluiW33jrACAl+tVwINni9XvoTwC+e80Xv1R19D9/bVXLChNcBX2LeY5QOT0/9jxzU= X-Received: by 2002:a67:c789:: with SMTP id t9mr25809822vsk.60.1629749499174; Mon, 23 Aug 2021 13:11:39 -0700 (PDT) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-2-brad@pensando.io> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 23 Aug 2021 22:11:27 +0200 Message-ID: Subject: Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control To: Brad Larson Cc: Andy Shevchenko , linux-arm Mailing List , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hi Brad, On Mon, Aug 23, 2021 at 6:31 PM Brad Larson wrote: > On Mon, Aug 23, 2021 at 12:50 AM Geert Uytterhoeven > wrote: > > On Mon, Aug 23, 2021 at 3:14 AM Brad Larson wrote: > > > On Mon, Mar 29, 2021 at 3:40 AM Andy Shevchenko > [...] > > > Regarding the above module question and Kconfig definition, since I > > > first looked at this and reviewed the comments I realized I should be > > > using builtin. The file gpio/Kconfig is currently this > > > > > > config GPIO_ELBA_SPICS > > > def_bool y > > > depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST > > > > That means the driver will default to yes by merely enabling > > COMPILE_TEST, which is a no-go. > > > > config GPIO_ELBA_SPICS > > bool "one-line summary" > > depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST > > default y if ARCH_PENSANDO_ELBA_SOC > > Thanks Geert, changed to this > > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -241,8 +241,9 @@ config GPIO_EIC_SPRD > Say yes here to support Spreadtrum EIC device. > > config GPIO_ELBA_SPICS > + bool "Pensando Elba SoC SPI Chip Select as GPIO support" > + depends on ARCH_PENSANDO_ELBA_SOC > def_bool y > - depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST So we're losing the COMPILE_TEST ability again? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds