From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B80CC433FE for ; Tue, 5 Oct 2021 15:26:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 730D161502 for ; Tue, 5 Oct 2021 15:26:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236066AbhJEP1z (ORCPT ); Tue, 5 Oct 2021 11:27:55 -0400 Received: from mail-vs1-f48.google.com ([209.85.217.48]:36837 "EHLO mail-vs1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234440AbhJEP1y (ORCPT ); Tue, 5 Oct 2021 11:27:54 -0400 Received: by mail-vs1-f48.google.com with SMTP id y28so10321393vsd.3; Tue, 05 Oct 2021 08:26:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KSfoUs1RyncvnmPC5NiMdbUYy+WE1in92GvUJZla4GY=; b=lTYDrruJNj2CHAgNSR5f7poVvASO1+IMQuNLlZDtGzJHapP4cRLXvs0YD6dbwBNP6G cf5aP9QC10xADxXjShVKnJ3K3bZ1w2H4YUNIO/y02uBlnDJMzUKJS4Z55Hb50fvy14NX O6IzaorxbulQxi1jw+fYE93JyBZ1/I0qo7Of3tCq45pyKVPLuHoye84T8aNEsfT5p0QL NtN22psd8zSsHQKQVUC0ObZvRni78xK9ycPaIiZ5+KBdnweHwjm8zbrGtNvLg3cSyHI8 O7z1MnLjS0DFSQXnS6Wg56/esPcQFLhQgWaucTNbcZZZ+6lAFVF7p69VTZnx8ch/care 31Dg== X-Gm-Message-State: AOAM531qmkE4Vdy9paW2+NTvG4l6KxBO2T/unSKvL/mQbnleLZqvN0S0 bFpXnUsGhiHat70DWweAPiwxq2Jc5cDXhBB7tDM= X-Google-Smtp-Source: ABdhPJywGwfpRqbIeYpGX+HZ2UWKkSYVpZ/hXxSNrmGd7JFi4IsId+z/R5soZJYSH3hdG3qWIJpUMzGfVNXr0Jb1zLM= X-Received: by 2002:a67:c295:: with SMTP id k21mr16616682vsj.37.1633447562966; Tue, 05 Oct 2021 08:26:02 -0700 (PDT) MIME-Version: 1.0 References: <20210928140721.8805-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210928140721.8805-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20210928140721.8805-4-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Tue, 5 Oct 2021 17:25:51 +0200 Message-ID: Subject: Re: [PATCH 3/6] spi: spi-rpc-if: Check return value of rpcif_sw_init() To: Lad Prabhakar Cc: Krzysztof Kozlowski , Rob Herring , Geert Uytterhoeven , Vignesh Raghavendra , Miquel Raynal , Richard Weinberger , Mark Brown , Philipp Zabel , Sergei Shtylyov , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , MTD Maling List , linux-spi , Wolfram Sang , Linux Kernel Mailing List , Linux-Renesas , Prabhakar , Biju Das Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hi Prabhakar, Thanks for your patch! On Tue, Sep 28, 2021 at 4:07 PM Lad Prabhakar wrote: > rpcif_sw_init() can fail so make sure we check the return value > of it and on error exit rpcif_spi_probe() callback with error code. Indeed, it will now fail earlier if CONFIG_RESET_CONTROLLER=n Patch sent https://lore.kernel.org/all/d4383bd1a97c0490c0bdc9dae5695f4230d4a420.1633447185.git.geert+renesas@glider.be > Fixes: eb8d6d464a27 ("spi: add Renesas RPC-IF driver") > Signed-off-by: Lad Prabhakar > Reviewed-by: Biju Das Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds