From: Emil Renner Berthing <emil.renner.berthing@gmail.com>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: Mark Brown <broonie@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-spi@vger.kernel.org,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/3] spi: rockchip: Config spi rx dma burst size depend on xfer length
Date: Wed, 22 Jul 2020 14:08:43 +0200 [thread overview]
Message-ID: <CANBLGcxZ+ps5TNzrHNHyjUZvSTrVQOHaqvB5H3tZVOow5z0aLQ@mail.gmail.com> (raw)
In-Reply-To: <20200722083737.8820-1-jon.lin@rock-chips.com>
On Wed, 22 Jul 2020 at 10:41, Jon Lin <jon.lin@rock-chips.com> wrote:
>
> The burst length can be adjusted according to the transmission
> length to improve the transmission rate
>
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
For the whole series you can add
Reviewed-by: Emil Renner Berthing <kernel@esmil.dk>
Tested-by: Emil Renner Berthing <kernel@esmil.dk>
> ---
> drivers/spi/spi-rockchip.c | 19 +++++++++++++++++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
> index 9b8a5e1233c0..63593a5b87fa 100644
> --- a/drivers/spi/spi-rockchip.c
> +++ b/drivers/spi/spi-rockchip.c
> @@ -384,6 +384,19 @@ static void rockchip_spi_dma_txcb(void *data)
> spi_finalize_current_transfer(ctlr);
> }
>
> +static u32 rockchip_spi_calc_burst_size(u32 data_len)
> +{
> + u32 i;
> +
> + /* burst size: 1, 2, 4, 8 */
> + for (i = 1; i < 8; i <<= 1) {
> + if (data_len & i)
> + break;
> + }
> +
> + return i;
> +}
> +
> static int rockchip_spi_prepare_dma(struct rockchip_spi *rs,
> struct spi_controller *ctlr, struct spi_transfer *xfer)
> {
> @@ -397,7 +410,8 @@ static int rockchip_spi_prepare_dma(struct rockchip_spi *rs,
> .direction = DMA_DEV_TO_MEM,
> .src_addr = rs->dma_addr_rx,
> .src_addr_width = rs->n_bytes,
> - .src_maxburst = 1,
> + .src_maxburst = rockchip_spi_calc_burst_size(xfer->len /
> + rs->n_bytes),
> };
>
> dmaengine_slave_config(ctlr->dma_rx, &rxconf);
> @@ -525,7 +539,8 @@ static void rockchip_spi_config(struct rockchip_spi *rs,
> writel_relaxed(rs->fifo_len / 2 - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
>
> writel_relaxed(rs->fifo_len / 2, rs->regs + ROCKCHIP_SPI_DMATDLR);
> - writel_relaxed(0, rs->regs + ROCKCHIP_SPI_DMARDLR);
> + writel_relaxed(rockchip_spi_calc_burst_size(xfer->len / rs->n_bytes) - 1,
> + rs->regs + ROCKCHIP_SPI_DMARDLR);
> writel_relaxed(dmacr, rs->regs + ROCKCHIP_SPI_DMACR);
>
> /* the hardware only supports an even clock divisor, so
> --
> 2.17.1
>
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2020-07-22 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 8:37 [PATCH v2 1/3] spi: rockchip: Config spi rx dma burst size depend on xfer length Jon Lin
2020-07-22 8:37 ` [PATCH v2 2/3] spi: rockchip: Support 64-location deep FIFOs Jon Lin
2020-07-22 8:37 ` [PATCH v2 3/3] spi: rockchip: Fix error in SPI slave pio read Jon Lin
2020-07-22 12:11 ` Emil Renner Berthing
2020-07-22 12:08 ` Emil Renner Berthing [this message]
2020-07-30 22:28 ` [PATCH v2 1/3] spi: rockchip: Config spi rx dma burst size depend on xfer length Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANBLGcxZ+ps5TNzrHNHyjUZvSTrVQOHaqvB5H3tZVOow5z0aLQ@mail.gmail.com \
--to=emil.renner.berthing@gmail.com \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=jon.lin@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).