From: Pantelis Antoniou <panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Alexander Sverdlin
<alexander.sverdlin-OYasijW0DpE@public.gmane.org>,
Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Matt Porter <matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Koen Kooi
<koen-QLwJDigV5abLmq1fohREcCpxlwaOVQ5f@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Alison Chaiken
<Alison_Chaiken-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>,
Dinh Nguyen <dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jan Lubbe <jluebbe-H4yykcOXDpCzQB+pC5nmwQ@public.gmane.org>,
Michael Stickel <ms-g5CePrrZ5ROELgA04lAiVw@public.gmane.org>,
Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
Dirk Behme <dirk.behme-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alan Tull
<delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Michael Bohan <mbohan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Ionut Nicu <ioan.nicu.ext-OYasijW0DpE@public.gmane.org>,
Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>,
Matt Ranostay <mranostay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Joel Becker <jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Subject: Re: [PATCH] of: spi: Export single device registration method and accessors (v2)
Date: Fri, 21 Nov 2014 17:44:00 +0200 [thread overview]
Message-ID: <CC185E77-95F6-4E4B-B431-59C9A9775453@antoniou-consulting.com> (raw)
In-Reply-To: <20141121153329.C4DDDC40D85-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
Hi Grant,
> On Nov 21, 2014, at 17:33 , Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:
>
> On Wed, 29 Oct 2014 12:22:04 +0000
> , Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> wrote:
>> On Wed, Oct 29, 2014 at 01:48:06PM +0200, Pantelis Antoniou wrote:
>>>> On Oct 29, 2014, at 12:14 , Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>>
>>>> This feels like there is an abstraction problem somewhere, whatever code
>>>> is supposed to use this is going to need to be taught about each
>>>> individual bus which is going to be tedious, I would expect that we'd
>>>> have something like the bus being able to provide a callback which will
>>>> get invoked whenever a new node appears on the parent node for the bus.
>>
>>> Thereâs a whole patchset that does exactly this.
>>> Look at "OF: spi: Add OF notifier handlerâ and youâll where this is used.
>>
>> I deleted that unread I'm afraid; one of the reasons that you should use
>> subject lines matching the styles for the subsystems is that it's one of
>> the things people use to filter out things that actually need attention,
>> if things are busy things that at first glance don't look terribly
>> relevant (like changes to the OF core in this case) are likely to get
>> looked at less urgently or just skipped.
>>
>> A quick glance suggests that this is adding code inside the SPI core so
>> it's still not explaining why anything is being exported, can you
>> clarify please?
>
> I have the same question. This doesn't look like it should be exporting
> symbols.
>
> Also, the way the patch is written causes a lot of code changes to get
> interleaved in the diff. It would be better to split into two patches;
> one that creates the new of_register_spi_device(), and a separate patch
> to add the other new functions. It would be certainly easier to review
> that way.
>
The diff does make a mess of things; it’s not that complex of a patch.
Your wish shall be granted. I’ll respin this over the weekend.
>>
>>>> SubmittingPatches says. Please also try to keep your CC list sane,
>>>> CCing random people just means that you're increasing the volume of mail
>>>> they have to process. I'm surprised kernel.org accepts so many CCs.
>>
>>>> I have to say I don't recall ever seeing v1...
>>
>>> All of them are in the CC list for a reason.
>>
>> This is a single, standalone SPI patch - you didn't send it as part of a
>> series (which is the only reason I read it).
>
> Yes, this is part of the OF overlay series. It should have at least been
> marked as [PATCH 7/8] and that it replaced the previous, buggy, patch 7.
>
> g.
>
Regards
— Pantelis
next prev parent reply other threads:[~2014-11-21 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 8:40 [PATCH] of: spi: Export single device registration method and accessors (v2) Pantelis Antoniou
2014-10-29 9:08 ` Alexander Sverdlin
[not found] ` <1414572037-11306-1-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2014-10-29 10:14 ` Mark Brown
[not found] ` <20141029101420.GT18557-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-10-29 11:48 ` Pantelis Antoniou
[not found] ` <6A3753C0-251A-4645-AD96-CB1D6521175F-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
2014-10-29 12:22 ` Mark Brown
[not found] ` <20141029122204.GG18557-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-11-21 15:33 ` Grant Likely
[not found] ` <20141121153329.C4DDDC40D85-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-11-21 15:44 ` Pantelis Antoniou [this message]
[not found] ` <CC185E77-95F6-4E4B-B431-59C9A9775453-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
2014-11-21 16:53 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC185E77-95F6-4E4B-B431-59C9A9775453@antoniou-consulting.com \
--to=panto-wvdstyuykro8r51topun2/c9hsw9inxf@public.gmane.org \
--cc=Alison_Chaiken-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org \
--cc=alexander.sverdlin-OYasijW0DpE@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dirk.behme-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ioan.nicu.ext-OYasijW0DpE@public.gmane.org \
--cc=jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org \
--cc=jluebbe-H4yykcOXDpCzQB+pC5nmwQ@public.gmane.org \
--cc=koen-QLwJDigV5abLmq1fohREcCpxlwaOVQ5f@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=mbohan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org \
--cc=mranostay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ms-g5CePrrZ5ROELgA04lAiVw@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).