linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 2.6.22-rc3] SPI -- Freescale iMX SPI controller driver
@ 2007-05-31 10:33 Andrea Paterniani
  0 siblings, 0 replies; only message in thread
From: Andrea Paterniani @ 2007-05-31 10:33 UTC (permalink / raw)
  To: Linux ARM Kernel, Andrew Morton, david-b-yBeKhBN/0LDR7s880joybQ,
	SPI Devel General, camilo.id-Re5JQEeQqe8AvxtiuMwx3w
  Cc: camilo.id-Re5JQEeQqe8AvxtiuMwx3w

Subject: [patch-2.6.22-rc3-spi_imx] arm: SPI controller driver for Freescale iMX
From: Andrea Paterniani <a.paterniani-03BXCEkGbFHYGGNLXY5/rw@public.gmane.org>

Kernel version: linux-2.6.22-rc3.
This is patch fixes 2 bugs:
> SPI_DMA_RHDMA bad value.
> Missing return value in setup() function (lost passing from
patch-2.6.20-rc4-spi_imx to patch-2.6.20-rc6-spi_imx).

Signed-off-by: Andrea Paterniani <a.paterniani-03BXCEkGbFHYGGNLXY5/rw@public.gmane.org>
---

diff -uprN -X linux-2.6.22-rc3/Documentation/dontdiff linux-2.6.22-rc3/drivers/spi/spi_imx.c
linux-2.6.22-rc3-spi_imx/drivers/spi/spi_imx.c
--- linux-2.6.22-rc3/drivers/spi/spi_imx.c	2007-04-26 05:08:32.000000000 +0200
+++ linux-2.6.22-rc3-spi_imx/drivers/spi/spi_imx.c	2007-05-31 12:09:07.000000000 +0200
@@ -121,7 +121,7 @@
 							32.768 KHz Clock */

 /* SPI DMA Register Bit Fields & Masks */
-#define SPI_DMA_RHDMA	(0xF << 4)	/* RXFIFO Half Status */
+#define SPI_DMA_RHDMA	(0x1 << 4)	/* RXFIFO Half Status */
 #define SPI_DMA_RFDMA	(0x1 << 5)      /* RXFIFO Full Status */
 #define SPI_DMA_TEDMA	(0x1 << 6)      /* TXFIFO Empty Status */
 #define SPI_DMA_THDMA	(0x1 << 7)      /* TXFIFO Half Status */
@@ -1355,6 +1355,7 @@ static int setup(struct spi_device *spi)
 		spi->bits_per_word,
 		spi_speed_hz(SPI_CONTROL_DATARATE_MIN),
 		spi->max_speed_hz);
+	return status;

 err_first_setup:
 	kfree(chip);


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-05-31 10:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-31 10:33 [patch 2.6.22-rc3] SPI -- Freescale iMX SPI controller driver Andrea Paterniani

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).