* [PATCH] spi: aspeed: Fix typo in mode_bits field for AST2600 platform
@ 2022-10-05 8:01 Chin-Ting Kuo
2022-10-05 8:28 ` Chin-Ting Kuo
0 siblings, 1 reply; 2+ messages in thread
From: Chin-Ting Kuo @ 2022-10-05 8:01 UTC (permalink / raw)
To: clg, chin-ting_kuo, broonie, joel, andrew, linux-aspeed, openbmc,
linux-spi, linux-kernel, BMC-SW, steven_lee
Both quad SPI TX and RX modes can be supported on AST2600.
Correct typo in mode_bits field in both ast2600_fmc_data
ast2600_spi_data structs.
Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
---
drivers/spi/spi-aspeed-smc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c
index a334e89add86..33cefcf18392 100644
--- a/drivers/spi/spi-aspeed-smc.c
+++ b/drivers/spi/spi-aspeed-smc.c
@@ -1163,7 +1163,7 @@ static const struct aspeed_spi_data ast2500_spi_data = {
static const struct aspeed_spi_data ast2600_fmc_data = {
.max_cs = 3,
.hastype = false,
- .mode_bits = SPI_RX_QUAD | SPI_RX_QUAD,
+ .mode_bits = SPI_RX_QUAD | SPI_TX_QUAD,
.we0 = 16,
.ctl0 = CE0_CTRL_REG,
.timing = CE0_TIMING_COMPENSATION_REG,
@@ -1178,7 +1178,7 @@ static const struct aspeed_spi_data ast2600_fmc_data = {
static const struct aspeed_spi_data ast2600_spi_data = {
.max_cs = 2,
.hastype = false,
- .mode_bits = SPI_RX_QUAD | SPI_RX_QUAD,
+ .mode_bits = SPI_RX_QUAD | SPI_TX_QUAD,
.we0 = 16,
.ctl0 = CE0_CTRL_REG,
.timing = CE0_TIMING_COMPENSATION_REG,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] spi: aspeed: Fix typo in mode_bits field for AST2600 platform
2022-10-05 8:01 [PATCH] spi: aspeed: Fix typo in mode_bits field for AST2600 platform Chin-Ting Kuo
@ 2022-10-05 8:28 ` Chin-Ting Kuo
0 siblings, 0 replies; 2+ messages in thread
From: Chin-Ting Kuo @ 2022-10-05 8:28 UTC (permalink / raw)
To: clg, broonie, joel, andrew, linux-aspeed, openbmc, linux-spi,
linux-kernel, BMC-SW, Steven Lee
Hi All,
> -----Original Message-----
> From: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
> Sent: Wednesday, October 5, 2022 4:01 PM
> Subject: [PATCH] spi: aspeed: Fix typo in mode_bits field for AST2600 platform
>
> Both quad SPI TX and RX modes can be supported on AST2600.
> Correct typo in mode_bits field in both ast2600_fmc_data ast2600_spi_data
> structs.
A missing "and" in "both ast2600_fmc_data ast2600_spi_data structs" in the commit message.
It will be updated in the next version later.
Chin-Ting
>
> Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
> ---
> drivers/spi/spi-aspeed-smc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c index
> a334e89add86..33cefcf18392 100644
> --- a/drivers/spi/spi-aspeed-smc.c
> +++ b/drivers/spi/spi-aspeed-smc.c
> @@ -1163,7 +1163,7 @@ static const struct aspeed_spi_data
> ast2500_spi_data = { static const struct aspeed_spi_data ast2600_fmc_data
> = {
> .max_cs = 3,
> .hastype = false,
> - .mode_bits = SPI_RX_QUAD | SPI_RX_QUAD,
> + .mode_bits = SPI_RX_QUAD | SPI_TX_QUAD,
> .we0 = 16,
> .ctl0 = CE0_CTRL_REG,
> .timing = CE0_TIMING_COMPENSATION_REG,
> @@ -1178,7 +1178,7 @@ static const struct aspeed_spi_data
> ast2600_fmc_data = { static const struct aspeed_spi_data ast2600_spi_data
> = {
> .max_cs = 2,
> .hastype = false,
> - .mode_bits = SPI_RX_QUAD | SPI_RX_QUAD,
> + .mode_bits = SPI_RX_QUAD | SPI_TX_QUAD,
> .we0 = 16,
> .ctl0 = CE0_CTRL_REG,
> .timing = CE0_TIMING_COMPENSATION_REG,
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-05 8:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-05 8:01 [PATCH] spi: aspeed: Fix typo in mode_bits field for AST2600 platform Chin-Ting Kuo
2022-10-05 8:28 ` Chin-Ting Kuo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).