linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Brandt <Chris.Brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
To: Sergei Shtylyov
	<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
	"linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Mason Yang <masonccyang-I/i+R0kf0WFNUHwG+Fw1Kw@public.gmane.org>
Subject: RE: [PATCH v2] spi: add Renesas RPC-IF driver
Date: Fri, 7 Feb 2020 22:36:42 +0000	[thread overview]
Message-ID: <TY1PR01MB1562509AEBD0B4460D3FEC798A1C0@TY1PR01MB1562.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <6515c5ec-8432-0b20-426d-0428bbdf3712-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

On Wed, Jan 15, 2020, Sergei Shtylyov wrote:
> Add the SPI driver for the Renesas RPC-IF.  It's the "front end" driver
> using the "back end" APIs in the main driver to talk to the real hardware.
> We only implement the 'spi-mem' interface -- there's no need to implemebt
> the usual SPI driver methods...

I tried these patches on an RZ/A1H RSK board.

At first, things were looking good. It would probe the SPI flash correctly
and I could read out data.

But, when I went to try and do an erase, it all went bad.
Looking at the actual SPI lines, the commands coming out don't look like what
I would expect from an MTD device.

For example, I do a 
  $ flash_eraseall /dev/mtd3
and all that comes out are Read Status commands (0x05).
All the write enables and erase commands are missing.

So, it looks like any command that is a write-only never actually sends
anything.

I did try and do a page program command:
  $ echo hello >  /dev/mtd3
It sent the page program command (0x12), but in this case, it still didn't work
because a write enable command was not sent first.
I assume the MTD layer is requesting the correct sequence of commands, but
Somehow this new driver is dropping of them.

Chris



  parent reply	other threads:[~2020-02-07 22:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ad503d6e-4739-9744-64b4-fd13f44ea6fe@cogentembedded.com>
     [not found] ` <ad503d6e-4739-9744-64b4-fd13f44ea6fe-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2020-01-15 20:46   ` [PATCH v2] spi: add Renesas RPC-IF driver Sergei Shtylyov
     [not found]     ` <6515c5ec-8432-0b20-426d-0428bbdf3712-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2020-02-07 22:36       ` Chris Brandt [this message]
     [not found]         ` <TY1PR01MB1562509AEBD0B4460D3FEC798A1C0-5SGCI54O2uKy/kJTUOSl63colHNk5qUtvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2020-02-10 18:43           ` Sergei Shtylyov
2020-02-10 18:06       ` Chris Brandt
     [not found]         ` <TYXPR01MB1568E8BCB6B80A77C91D98998A190-enDngAEzY3rnUoU5SHyUhXcolHNk5qUtvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2020-02-10 19:34           ` Chris Brandt
2020-05-08 19:54 ` [PATCH v3] " Sergei Shtylyov
2020-06-13 19:18 ` [PATCH v4] " Sergei Shtylyov
2020-06-15 23:41   ` Mark Brown
2020-06-16  8:24     ` Sergei Shtylyov
2020-06-16  8:38       ` Mark Brown
2020-06-16  8:48         ` Sergei Shtylyov
2020-06-16  9:34           ` Mark Brown
2020-06-16 12:55             ` Sergei Shtylyov
2020-06-16 14:32               ` Mark Brown
2020-06-16  9:26         ` Sergei Shtylyov
2020-06-16  9:34           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY1PR01MB1562509AEBD0B4460D3FEC798A1C0@TY1PR01MB1562.jpnprd01.prod.outlook.com \
    --to=chris.brandt-zm6kxycvzfbbdgjk7y7tuq@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=masonccyang-I/i+R0kf0WFNUHwG+Fw1Kw@public.gmane.org \
    --cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).