linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Gong <yibin.gong@nxp.com>
To: "Fuzzey, Martin" <martin.fuzzey@flowbird.group>
Cc: "Sascha Hauer" <s.hauer@pengutronix.de>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Fabio Estevam" <festevam@gmail.com>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"Will Deacon" <will.deacon@arm.com>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v7 00/13] add ecspi ERR009165 for i.mx6/7 soc family
Date: Wed, 15 Apr 2020 14:06:11 +0000	[thread overview]
Message-ID: <VE1PR04MB6638479E728795FA28F7614A89DB0@VE1PR04MB6638.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CANh8QzwanSewjJ98HL_yR1juiHo1RN77JQyNNKrMrud3B0dnww@mail.gmail.com>

On 2020/04/15 17:47 Fuzzey, Martin <martin.fuzzey@flowbird.group> wrote:d
> Hi Robin,
> 
> 
> On Wed, 11 Mar 2020 at 09:35, Robin Gong <yibin.gong@nxp.com> wrote:
> >
> > There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO
> > transfer to be send twice in DMA mode. Please get more information from:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
> >
> nxp.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&amp;data=02%7C01%7C
> yibin.g
> >
> ong%40nxp.com%7Caf3ad866d3274fce2aaf08d7e121ffb8%7C686ea1d3bc2b4c
> 6fa92
> >
> cd99c5c301635%7C0%7C1%7C637225408450989272&amp;sdata=av3%2FnSaP
> pQ6rHlkmFAooZS6P8fnxC%2Bm7sJrBg30dUZs%3D&amp;reserved=0. The
> workaround is adding new sdma ram script which works in XCH  mode as PIO
> inside sdma instead of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0.
> The issue should be exist on all legacy i.mx6/7 soc family before i.mx6ul.
> > NXP fix this design issue from i.mx6ul, so newer chips including
> > i.mx6ul/ 6ull/6sll do not need this workaroud anymore. All other
> > i.mx6/7/8 chips still need this workaroud. This patch set add new
> 'fsl,imx6ul-ecspi'
> > for ecspi driver and 'ecspi_fixed' in sdma driver to choose if need
> > errata or not.
> > The first two reverted patches should be the same issue, though, it
> > seems 'fixed' by changing to other shp script. Hope Sean or Sascha
> > could have the chance to test this patch set if could fix their issues.
> > Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work
> > on i.mx8mm because the event id is zero.
> >
> > PS:
> >    Please get sdma firmware from below linux-firmware and copy it to
> > your local rootfs /lib/firmware/imx/sdma.
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> >
> kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ffirmware%2Flinux-firm
> w
> >
> are.git%2Ftree%2Fimx%2Fsdma&amp;data=02%7C01%7Cyibin.gong%40nxp.co
> m%7C
> >
> af3ad866d3274fce2aaf08d7e121ffb8%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C
> >
> 0%7C1%7C637225408450999264&amp;sdata=%2BgcoGJqUKAkZbc%2BXgtXPsp
> d6X7p0G
> > Ds7ndyHY4i1wp0%3D&amp;reserved=0
> >
> 
> A couple of questions
> 
> 1) Is this series needed for the i.MX6DL? (the document you linked only seems
> to mention i.MX6D/Q
Yes, it's needed for all i.mx6 legacy chips include i.MX6DL since they share the same ecspi IP. Show the i.MX6D/Q document as a sample.
> 2) If the laterst SDMA firmware mentionned above is used will this break
> systems running mainline kernels without this patch series applied?
No basic function broken with the latest SDMA firmware and mainline kernel without this patch series, but the ecspi issue ERR009165 is still here then.

      reply	other threads:[~2020-04-15 14:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 16:36 Robin Gong
2020-03-11 16:36 ` [PATCH v7 08/13] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong
     [not found] ` <1583944596-23410-1-git-send-email-yibin.gong-3arQi8VN3Tc@public.gmane.org>
2020-03-11 16:36   ` [PATCH v7 01/13] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong
2020-03-11 16:36   ` [PATCH v7 02/13] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong
2020-03-11 16:36   ` [PATCH v7 03/13] Revert "dmaengine: imx-sdma: fix context cache" Robin Gong
2020-03-11 16:36   ` [PATCH v7 04/13] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong
2020-03-11 16:36   ` [PATCH v7 05/13] dmaengine: imx-sdma: remove dupilicated sdma_load_context Robin Gong
2020-03-11 16:36   ` [PATCH v7 06/13] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong
2020-03-11 16:36   ` [PATCH v7 07/13] spi: imx: fix ERR009165 Robin Gong
2020-03-11 16:36   ` [PATCH v7 09/13] spi: imx: add new i.mx6ul compatible name in binding doc Robin Gong
2020-03-11 16:36   ` [PATCH v7 10/13] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Robin Gong
2020-03-11 16:36   ` [PATCH v7 12/13] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm Robin Gong
2020-03-11 16:36 ` [PATCH v7 11/13] dma: imx-sdma: add i.mx6ul compatible name Robin Gong
2020-03-11 16:36 ` [PATCH v7 13/13] dmaengine: imx-sdma: add uart rom script Robin Gong
2020-04-15  8:41 ` [PATCH v7 00/13] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong
2020-04-15  9:19   ` Mark Brown
2020-04-15 13:57     ` Robin Gong
2020-04-15  9:47 ` Fuzzey, Martin
2020-04-15 14:06   ` Robin Gong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR04MB6638479E728795FA28F7614A89DB0@VE1PR04MB6638.eurprd04.prod.outlook.com \
    --to=yibin.gong@nxp.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.fuzzey@flowbird.group \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vkoul@kernel.org \
    --cc=will.deacon@arm.com \
    --subject='RE: [PATCH v7 00/13] add ecspi ERR009165 for i.mx6/7 soc family' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).