From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] parport: Introduce module_parport_driver() helper macro
Date: Fri, 26 Feb 2021 19:03:09 +0200 [thread overview]
Message-ID: <YDkpzZ8jL7O9HJuG@smile.fi.intel.com> (raw)
In-Reply-To: <20210216110741.1286-1-andriy.shevchenko@linux.intel.com>
On Tue, Feb 16, 2021 at 01:07:39PM +0200, Andy Shevchenko wrote:
> Introduce module_parport_driver() helper macro to reduce boilerplate
> in the existing and new code.
Sudip, any comments on this?
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: fixed typo in the macro
> include/linux/parport.h | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/parport.h b/include/linux/parport.h
> index 1fb508c19e83..54539b80021e 100644
> --- a/include/linux/parport.h
> +++ b/include/linux/parport.h
> @@ -301,9 +301,19 @@ int __must_check __parport_register_driver(struct parport_driver *,
> __parport_register_driver(driver, THIS_MODULE, KBUILD_MODNAME)
>
> /* Unregister a high-level driver. */
> -extern void parport_unregister_driver (struct parport_driver *);
> void parport_unregister_driver(struct parport_driver *);
>
> +/**
> + * module_parport_driver() - Helper macro for registering a modular parport driver
> + * @__parport_driver: struct parport_driver to be used
> + *
> + * Helper macro for parport drivers which do not do anything special in module
> + * init and exit. This eliminates a lot of boilerplate. Each module may only
> + * use this macro once, and calling it replaces module_init() and module_exit().
> + */
> +#define module_parport_driver(__parport_driver) \
> + module_driver(__parport_driver, parport_register_driver, parport_unregister_driver)
> +
> /* If parport_register_driver doesn't fit your needs, perhaps
> * parport_find_xxx does. */
> extern struct parport *parport_find_number (int);
> --
> 2.30.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-26 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 11:07 [PATCH v2 1/3] parport: Introduce module_parport_driver() helper macro Andy Shevchenko
2021-02-16 11:07 ` [PATCH v2 2/3] spi: butterfly: Switch to use module_parport_driver() Andy Shevchenko
2021-02-16 11:07 ` [PATCH v2 3/3] spi: lm70llp: " Andy Shevchenko
2021-02-26 17:03 ` Andy Shevchenko [this message]
2021-02-28 23:27 ` [PATCH v2 1/3] parport: Introduce module_parport_driver() helper macro Sudip Mukherjee
2021-03-01 12:11 ` Andy Shevchenko
2021-03-02 14:51 ` Sudip Mukherjee
2021-03-02 15:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDkpzZ8jL7O9HJuG@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).