From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DDF7C433ED for ; Thu, 22 Apr 2021 11:18:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1840D6144A for ; Thu, 22 Apr 2021 11:18:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235863AbhDVLTN (ORCPT ); Thu, 22 Apr 2021 07:19:13 -0400 Received: from mga12.intel.com ([192.55.52.136]:24052 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236087AbhDVLTN (ORCPT ); Thu, 22 Apr 2021 07:19:13 -0400 IronPort-SDR: qOOhlRwEouIHjKMQ0QicD5u+8TSb4vPYVf/PCkCuNC/1xR5DvShp3pcADFCVbRgiYeLYpHepPY GsQ54pzXIzSA== X-IronPort-AV: E=McAfee;i="6200,9189,9961"; a="175353917" X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="175353917" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2021 04:18:37 -0700 IronPort-SDR: YKtPdeYyAb17FoK2RSAGl3PBWg3fq2Ve7xGQ/FHHu4Kd7KdA41vuYaFFqqM+OLbusLOaswCTpy A0Sp2Ul6aVKQ== X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="453227876" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2021 04:18:35 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lZXLt-006G58-MS; Thu, 22 Apr 2021 14:18:33 +0300 Date: Thu, 22 Apr 2021 14:18:33 +0300 From: Andy Shevchenko To: Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] spi: Rename enable1 to activate in spi_set_cs() Message-ID: References: <20210420131846.75983-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210420131846.75983-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Tue, Apr 20, 2021 at 04:18:46PM +0300, Andy Shevchenko wrote: > The enable1 is confusing name. Change it to clearly show what is > the intention behind it. No functional changes. Is this one okay or does it require some work? -- With Best Regards, Andy Shevchenko