From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB1FEC433F5 for ; Sat, 22 Jan 2022 15:18:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234038AbiAVPSN (ORCPT ); Sat, 22 Jan 2022 10:18:13 -0500 Received: from 12.mo581.mail-out.ovh.net ([178.33.107.167]:33899 "EHLO 12.mo581.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233950AbiAVPSN (ORCPT ); Sat, 22 Jan 2022 10:18:13 -0500 X-Greylist: delayed 12602 seconds by postgrey-1.27 at vger.kernel.org; Sat, 22 Jan 2022 10:18:13 EST Received: from player157.ha.ovh.net (unknown [10.109.146.143]) by mo581.mail-out.ovh.net (Postfix) with ESMTP id 1E7D122567 for ; Sat, 22 Jan 2022 10:32:46 +0000 (UTC) Received: from etezian.org (82-181-27-157.bb.dnainternet.fi [82.181.27.157]) (Authenticated sender: andi@etezian.org) by player157.ha.ovh.net (Postfix) with ESMTPSA id 8612B269A01DF; Sat, 22 Jan 2022 10:32:31 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-97G002d1f1703d-60b6-4d6e-9bce-356b1a80796e, 47613193A4C2821AFA139AF0D7345AE9E747044F) smtp.auth=andi@etezian.org X-OVh-ClientIp: 82.181.27.157 Date: Sat, 22 Jan 2022 12:32:30 +0200 From: Andi Shyti To: Alim Akhtar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linus.walleij@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski@canonical.com, linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com, broonie@kernel.org, andi@etezian.org, linux-spi@vger.kernel.org, linux-fsd@tesla.com, Aswani Reddy Subject: Re: [PATCH v2 2/3] spi: s3c64xx: Add spi port configuration for Tesla FSD SoC Message-ID: References: <20220120192438.25555-1-alim.akhtar@samsung.com> <20220120192438.25555-3-alim.akhtar@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220120192438.25555-3-alim.akhtar@samsung.com> X-Ovh-Tracer-Id: 15946683333332503243 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvvddrvddvgddujecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughiucfuhhihthhiuceorghnughisegvthgviihirghnrdhorhhgqeenucggtffrrghtthgvrhhnpedtgfduudfhfeeuueejfeeihedtfeetgfegveehgfeuleelhfduteegieekudeifeenucfkpheptddrtddrtddrtddpkedvrddukedurddvjedrudehjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepphhlrgihvghrudehjedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegrnhguihesvghtvgiiihgrnhdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhsphhisehvghgvrhdrkhgvrhhnvghlrdhorhhg Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hi Alim, > Adds compatible and port configuration for spi controller > for Tesla Full Self-Driving SoC. please next time be a bit clearer in the cover letter. I think you want to say: "This patch adds the compatible..." But it's anyway recommended to use the imperative form: "Add the compatible blah blah blah...." > Cc: linux-fsd@tesla.com > Signed-off-by: Aswani Reddy > Signed-off-by: Alim Akhtar Other than that, looks good to me: Reviewed-by: Andi Shyti Thanks, Andi