From: Abel Vesa <abel.vesa@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Stuart Yoder <stuyoder@gmail.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Andy Gross <agross@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Mark Brown <broonie@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org,
linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
linux-spi@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v3 01/11] driver: platform: Add helper for safer setting of driver_override
Date: Mon, 28 Feb 2022 13:56:50 +0200 [thread overview]
Message-ID: <Yhy4gvuYszZG3+e+@abelvesa> (raw)
In-Reply-To: <b428f7b0-9f3e-466c-9386-9f72f13ebbd0@canonical.com>
On 22-02-28 12:30:45, Krzysztof Kozlowski wrote:
> On 28/02/2022 11:51, Abel Vesa wrote:
> > On 22-02-27 14:52:04, Krzysztof Kozlowski wrote:
> >> Several core drivers and buses expect that driver_override is a
> >> dynamically allocated memory thus later they can kfree() it.
> >>
> >> However such assumption is not documented, there were in the past and
> >> there are already users setting it to a string literal. This leads to
> >> kfree() of static memory during device release (e.g. in error paths or
> >> during unbind):
> >>
> >> kernel BUG at ../mm/slub.c:3960!
> >> Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM
> >> ...
> >> (kfree) from [<c058da50>] (platform_device_release+0x88/0xb4)
> >> (platform_device_release) from [<c0585be0>] (device_release+0x2c/0x90)
> >> (device_release) from [<c0a69050>] (kobject_put+0xec/0x20c)
> >> (kobject_put) from [<c0f2f120>] (exynos5_clk_probe+0x154/0x18c)
> >> (exynos5_clk_probe) from [<c058de70>] (platform_drv_probe+0x6c/0xa4)
> >> (platform_drv_probe) from [<c058b7ac>] (really_probe+0x280/0x414)
> >> (really_probe) from [<c058baf4>] (driver_probe_device+0x78/0x1c4)
> >> (driver_probe_device) from [<c0589854>] (bus_for_each_drv+0x74/0xb8)
> >> (bus_for_each_drv) from [<c058b48c>] (__device_attach+0xd4/0x16c)
> >> (__device_attach) from [<c058a638>] (bus_probe_device+0x88/0x90)
> >> (bus_probe_device) from [<c05871fc>] (device_add+0x3dc/0x62c)
> >> (device_add) from [<c075ff10>] (of_platform_device_create_pdata+0x94/0xbc)
> >> (of_platform_device_create_pdata) from [<c07600ec>] (of_platform_bus_create+0x1a8/0x4fc)
> >> (of_platform_bus_create) from [<c0760150>] (of_platform_bus_create+0x20c/0x4fc)
> >> (of_platform_bus_create) from [<c07605f0>] (of_platform_populate+0x84/0x118)
> >> (of_platform_populate) from [<c0f3c964>] (of_platform_default_populate_init+0xa0/0xb8)
> >> (of_platform_default_populate_init) from [<c01031f8>] (do_one_initcall+0x8c/0x404)
> >> (do_one_initcall) from [<c0f012c0>] (kernel_init_freeable+0x3d0/0x4d8)
> >> (kernel_init_freeable) from [<c0a7def0>] (kernel_init+0x8/0x114)
> >> (kernel_init) from [<c01010b4>] (ret_from_fork+0x14/0x20)
> >>
> >> Provide a helper which clearly documents the usage of driver_override.
> >> This will allow later to reuse the helper and reduce amount of
> >> duplicated code.
> >>
> >> Convert the platform driver to use new helper and make the
> >> driver_override field const char (it is not modified by the core).
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >> ---
> >> drivers/base/driver.c | 51 +++++++++++++++++++++++++++++++++
> >> drivers/base/platform.c | 28 +++---------------
> >> include/linux/device/driver.h | 2 ++
> >> include/linux/platform_device.h | 7 ++++-
> >> 4 files changed, 63 insertions(+), 25 deletions(-)
> >>
> >> diff --git a/drivers/base/driver.c b/drivers/base/driver.c
> >> index 8c0d33e182fd..353750b0bbc5 100644
> >> --- a/drivers/base/driver.c
> >> +++ b/drivers/base/driver.c
> >> @@ -30,6 +30,57 @@ static struct device *next_device(struct klist_iter *i)
> >> return dev;
> >> }
> >>
> >> +/**
> >> + * driver_set_override() - Helper to set or clear driver override.
> >> + * @dev: Device to change
> >> + * @override: Address of string to change (e.g. &device->driver_override);
> >> + * The contents will be freed and hold newly allocated override.
> >> + * @s: NUL terminated string, new driver name to force a match, pass empty
> >> + * string to clear it
> >> + * @len: length of @s
> >> + *
> >> + * Helper to set or clear driver override in a device, intended for the cases
> >> + * when the driver_override field is allocated by driver/bus code.
> >> + *
> >> + * Returns: 0 on success or a negative error code on failure.
> >> + */
> >> +int driver_set_override(struct device *dev, const char **override,
> >> + const char *s, size_t len)
> >
> > TBH, I think it would make more sense to have this generic
> > driver_set_override receive only the dev and the string. And then,
> > each bus type will have their own implementation that handle things
> > their own way. This would allow all the drivers that will use this to
> > do something like this:
> >
> > ret = driver_set_override(&pdev->dev, "override_string");
> >
> > I think it would look more cleaner.
> >
>
> The interface in general is not for the drivers. Drivers use it in
> exceptions (few cases in entire kernel) but many times they actually do
> not need to.
>
> Adding a dedicated driver_set_override() brings intention that such
> usage is welcomed... but it's not. :)
I understand that. Anyway, I was more focused on this looking cleaner.
But I'll let the others weigh in on this before applying the imx clk
patch.
Thanks.
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2022-02-28 11:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 13:52 [PATCH v3 00/11] Fix broken usage of driver_override (and kfree of static memory) Krzysztof Kozlowski
2022-02-27 13:52 ` [PATCH v3 01/11] driver: platform: Add helper for safer setting of driver_override Krzysztof Kozlowski
2022-02-28 10:51 ` Abel Vesa
2022-02-28 11:30 ` Krzysztof Kozlowski
2022-02-28 11:56 ` Abel Vesa [this message]
2022-02-28 20:03 ` Bjorn Helgaas
2022-03-01 8:49 ` Krzysztof Kozlowski
2022-02-27 13:52 ` [PATCH v3 02/11] amba: Use driver_set_override() instead of open-coding Krzysztof Kozlowski
2022-02-27 13:52 ` [PATCH v3 03/11] fsl-mc: " Krzysztof Kozlowski
2022-02-27 13:52 ` [PATCH v3 04/11] hv: " Krzysztof Kozlowski
2022-02-27 15:53 ` Michael Kelley (LINUX)
2022-02-27 13:52 ` [PATCH v3 05/11] PCI: " Krzysztof Kozlowski
2022-02-28 20:06 ` Bjorn Helgaas
2022-03-01 8:41 ` Krzysztof Kozlowski
2022-02-27 13:52 ` [PATCH v3 06/11] s390: cio: " Krzysztof Kozlowski
2022-03-01 16:01 ` Vineeth Vijayan
2022-03-02 11:01 ` Krzysztof Kozlowski
2022-02-27 13:53 ` [PATCH v3 07/11] spi: Use helper for safer setting of driver_override Krzysztof Kozlowski
2022-02-28 13:07 ` Mark Brown
2022-02-27 13:53 ` [PATCH v3 08/11] vdpa: " Krzysztof Kozlowski
2022-02-27 13:53 ` [PATCH v3 09/11] clk: imx: scu: Fix kfree() of static memory on setting driver_override Krzysztof Kozlowski
2022-02-28 10:55 ` Abel Vesa
2022-02-27 13:53 ` [PATCH v3 10/11] slimbus: qcom-ngd: " Krzysztof Kozlowski
2022-03-01 17:28 ` Srinivas Kandagatla
2022-02-27 13:53 ` [PATCH v3 11/11] rpmsg: " Krzysztof Kozlowski
2022-03-11 20:19 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yhy4gvuYszZG3+e+@abelvesa \
--to=abel.vesa@nxp.com \
--cc=agordeev@linux.ibm.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=broonie@kernel.org \
--cc=decui@microsoft.com \
--cc=festevam@gmail.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hca@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kys@microsoft.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=oberpar@linux.ibm.com \
--cc=rafael@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=sthemmin@microsoft.com \
--cc=stuyoder@gmail.com \
--cc=svens@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=vneethv@linux.ibm.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).