From: Vignesh Raghavendra <vigneshr-l0cyMroinI0@public.gmane.org>
To: "Ramuthevar,
Vadivel MuruganX"
<vadivel.muruganx.ramuthevar-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
<broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
<cheol.yong.kim-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
<qi-ming.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v7 2/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller
Date: Thu, 23 Jan 2020 15:28:09 +0530 [thread overview]
Message-ID: <a4b33129-5ac3-d4d1-c8ba-f170f0f9ee03@ti.com> (raw)
In-Reply-To: <1aedd2ad-5795-2500-286f-fb55209991f8-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On 23/01/20 3:14 pm, Ramuthevar, Vadivel MuruganX wrote:
>>> +};
>>> +
>>> +struct spi_mem_op_cadence {
>>> + const void *tx_buf;
>>> + void *rx_buf;
>>> + u32 len;
>>> + u32 tx_nbits:3;
>>> + u32 rx_nbits:3;
>>> +};
>>> +
>> Please drop thesee.. See further below for more info.
> it's required for qspi-nand.
I don't see a need to mimic fields of spi_mem_op inside this driver. Why
not use them directly where needed?
Looking at the patch:
rx_nbits is never used.
tx_nbits is assigned value but never used
rx_buf is never used
tx_buf aliases to addrbuf which can be easily derived from op->addr.val
--
Regards
Vignesh
next prev parent reply other threads:[~2020-01-23 9:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 9:13 [PATCH v7 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
[not found] ` <20200122091340.43986-1-vadivel.muruganx.ramuthevar-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2020-01-22 9:13 ` [PATCH v7 1/2] dt-bindings: spi: Add schema for Cadence QSPI Controller driver Ramuthevar,Vadivel MuruganX
2020-01-22 9:13 ` [PATCH v7 2/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
[not found] ` <20200122091340.43986-3-vadivel.muruganx.ramuthevar-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2020-01-22 9:58 ` Simon Goldschmidt
[not found] ` <CAAh8qswkbD2bc2QBzt=pHd5OyT00sYqffoEYe4Aiij_vMWxZZw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-01-23 2:16 ` Ramuthevar, Vadivel MuruganX
2020-01-23 2:32 ` Ramuthevar, Vadivel MuruganX
2020-01-23 8:15 ` Vignesh Raghavendra
[not found] ` <617ec5c7-59a0-1e09-bdd7-126a5792889d-l0cyMroinI0@public.gmane.org>
2020-01-23 9:44 ` Ramuthevar, Vadivel MuruganX
[not found] ` <1aedd2ad-5795-2500-286f-fb55209991f8-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2020-01-23 9:58 ` Vignesh Raghavendra [this message]
[not found] ` <a4b33129-5ac3-d4d1-c8ba-f170f0f9ee03-l0cyMroinI0@public.gmane.org>
2020-01-23 10:05 ` Ramuthevar, Vadivel MuruganX
2020-01-23 10:06 ` Ramuthevar, Vadivel MuruganX
2020-01-22 9:18 [PATCH v7 0/2] " Ramuthevar,Vadivel MuruganX
[not found] ` <20200122091809.43069-1-vadivel.muruganx.ramuthevar-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2020-01-22 9:18 ` [PATCH v7 2/2] " Ramuthevar,Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4b33129-5ac3-d4d1-c8ba-f170f0f9ee03@ti.com \
--to=vigneshr-l0cymroini0@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=cheol.yong.kim-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=qi-ming.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vadivel.muruganx.ramuthevar-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).