linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Mark Brown <broonie@kernel.org>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Jie Yang <yang.jie@linux.intel.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-spi@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] spi: pxa2xx: Enable support for compile-testing
Date: Mon, 10 Feb 2020 08:21:18 -0600	[thread overview]
Message-ID: <abf31c4f-638c-0732-6dc3-957a903e8d56@linux.intel.com> (raw)
In-Reply-To: <20200210093027.6672-1-geert@linux-m68k.org>



On 2/10/20 3:30 AM, Geert Uytterhoeven wrote:
> m68k/allmodconfig:
> 
>      WARNING: unmet direct dependencies detected for SPI_PXA2XX
>        Depends on [n]: SPI [=y] && SPI_MASTER [=y] && (ARCH_PXA || ARCH_MMP || PCI [=n] || ACPI)
>        Selected by [m]:
>        - SND_SOC_INTEL_BDW_RT5677_MACH [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_INTEL_MACH [=y] && (SND_SOC_INTEL_HASWELL [=n] || SND_SOC_SOF_BROADWELL [=m]) && I2C [=m] && (I2C_DESIGNWARE_PLATFORM [=m] || COMPILE_TEST [=y]) && (GPIOLIB [=y] || COMPILE_TEST [=y]) && (X86_INTEL_LPSS || COMPILE_TEST [=y]) && SPI_MASTER [=y]
> 
> This happens because SND_SOC_INTEL_BDW_RT5677_MACH selects SPI_PXA2XX,
> and the former depends on COMPILE_TEST, while the latter does not.
> 
> Fix this by enabling compile-testing for SPI_PXA2XX.
> 
> Fixes: 630db1549356f644 ("ASoC: Intel: bdw-rt5677: fix Kconfig dependencies")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Makes sense.

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---
>   drivers/spi/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index ee96708aa3a77156..2e1c3a575f7a6cc3 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -557,7 +557,7 @@ config SPI_PPC4xx
>   
>   config SPI_PXA2XX
>   	tristate "PXA2xx SSP SPI master"
> -	depends on (ARCH_PXA || ARCH_MMP || PCI || ACPI)
> +	depends on ARCH_PXA || ARCH_MMP || PCI || ACPI || COMPILE_TEST
>   	select PXA_SSP if ARCH_PXA || ARCH_MMP
>   	help
>   	  This enables using a PXA2xx or Sodaville SSP port as a SPI master
> 

  reply	other threads:[~2020-02-10 14:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10  9:30 [PATCH] spi: pxa2xx: Enable support for compile-testing Geert Uytterhoeven
2020-02-10 14:21 ` Pierre-Louis Bossart [this message]
     [not found] ` <20200210093027.6672-1-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2020-02-11 15:49   ` Applied "spi: pxa2xx: Enable support for compile-testing" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abf31c4f-638c-0732-6dc3-957a903e8d56@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=geert@linux-m68k.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).