From: Marek Vasut <marex@denx.de>
To: Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] spi: imx: mx51-ecspi: Reinstate low-speed CONFIGREG delay
Date: Sun, 18 Jul 2021 23:20:36 +0200 [thread overview]
Message-ID: <ac7f2fd1-e61d-07ce-162a-9b5cdc91d145@denx.de> (raw)
In-Reply-To: <162567934678.18850.1622229665696547684.b4-ty@kernel.org>
On 7/7/21 7:52 PM, Mark Brown wrote:
> On Sat, 3 Jul 2021 04:23:00 +0200, Marek Vasut wrote:
>> Since 00b80ac935539 ("spi: imx: mx51-ecspi: Move some initialisation to
>> prepare_message hook."), the MX51_ECSPI_CONFIG write no longer happens
>> in prepare_transfer hook, but rather in prepare_message hook, however
>> the MX51_ECSPI_CONFIG delay is still left in prepare_transfer hook and
>> thus has no effect. This leads to low bus frequency operation problems
>> described in 6fd8b8503a0dc ("spi: spi-imx: Fix out-of-order CS/SCLK
>> operation at low speeds") again.
>>
>> [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
>
> Thanks!
>
> [1/1] spi: imx: mx51-ecspi: Reinstate low-speed CONFIGREG delay
> commit: 135cbd378eab336da15de9c84bbb22bf743b38a5
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
>
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
I messed that one up, here is the incremental fix:
https://patchwork.kernel.org/project/spi-devel-general/patch/20210718211143.143557-1-marex@denx.de/
prev parent reply other threads:[~2021-07-18 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 2:23 [PATCH] spi: imx: mx51-ecspi: Reinstate low-speed CONFIGREG delay Marek Vasut
2021-07-07 17:52 ` Mark Brown
2021-07-18 21:20 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac7f2fd1-e61d-07ce-162a-9b5cdc91d145@denx.de \
--to=marex@denx.de \
--cc=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).