From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07CAEC12002 for ; Fri, 16 Jul 2021 20:44:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6FB4613F8 for ; Fri, 16 Jul 2021 20:44:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234171AbhGPUrq (ORCPT ); Fri, 16 Jul 2021 16:47:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26513 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234129AbhGPUrp (ORCPT ); Fri, 16 Jul 2021 16:47:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626468289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hOSl7T8uaeeFLE5+UEIkT2Ky1iFxWg4XaCDh/v6oAM=; b=ewDQBrMt3ig4NWmEIa1ViMiivyQ59UnbyIfDVQQe/FDNm+njmbbNOBi3UMF4zS2FVXgoB+ QeGKv9m/TFZAoDJ52IO28WFCrY+GiMTI3bMLqAIZedUCVf9cmVL9hhxnFwK3ftleGjh+Ym KQJNe+LM/eXW/NKkQy2DzO3LQ7Dgk6U= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-ExYtnYoiOK2k4u4tb1Axwg-1; Fri, 16 Jul 2021 16:44:48 -0400 X-MC-Unique: ExYtnYoiOK2k4u4tb1Axwg-1 Received: by mail-qv1-f69.google.com with SMTP id d17-20020a0cfe910000b02902e01fc8ee77so7486369qvs.21 for ; Fri, 16 Jul 2021 13:44:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=2hOSl7T8uaeeFLE5+UEIkT2Ky1iFxWg4XaCDh/v6oAM=; b=ssVDCprTmo4on3gBOYeR+GzR/pGCnUPm1a8iAN6+tXZ3qah1+1+P8ZVMSTk0Eh/3t8 dTatECbXzXbRP136kC50AXQIebRl3RWmRDN3xr1tuFBfv3aU6BNxub54OQqLMBmjlWBH MNquqB2FSrfzJYNF+vpwRfmVFHVcJ28QrRVreLT4xCNKhB6ExjUZL5K9Q6eI2h2c/hu4 q6EJLWT7XINy72EzJdcJ78Gh093coBxXGPFdvGN6hvY0sTiDLRvIm6X/uRYUkAxMX20j lNIHQdpONijUe9kVUNNuNXNj7kQyGdV/hQRIFFJDiIICbDIhbCFCYGqMZHBwbniKid6K d91w== X-Gm-Message-State: AOAM532oXhcZkNvV+gaG+0ntPeDyqgJ2dse1L9Vphjz5tFDhTeI0FSNm ObaWdoag0FlV0BfTTaHWgfwP1LB45fKW0rqbX0VeCqbZKNLE3ZofE3ZQNlvku7kLHSXX6ec4Wud +z2qrm6c+iefJyRlHQzYs4ScHnobyC79ZetKiaIqBHA8yXdM/HjOoKTiDODLOHO8bL+M= X-Received: by 2002:a0c:cdc6:: with SMTP id a6mr12055716qvn.15.1626468288421; Fri, 16 Jul 2021 13:44:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySk4FYXysPvZ8XbnmBZ1swg1qoJWhXD2QzxodwEZF9W9BDb8u8S6hPtBgK6GGEILviRId/pg== X-Received: by 2002:a0c:cdc6:: with SMTP id a6mr12055691qvn.15.1626468288230; Fri, 16 Jul 2021 13:44:48 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id a19sm3479074qtb.54.2021.07.16.13.44.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jul 2021 13:44:47 -0700 (PDT) Subject: Re: [PATCH v5 2/3] spi: spi-altera-dfl: support n5010 feature revision To: =?UTF-8?Q?Martin_Hundeb=c3=b8ll?= , Wu Hao , Moritz Fischer , Xu Yilun , Jean Delvare , Guenter Roeck , Mark Brown Cc: =?UTF-8?Q?Martin_Hundeb=c3=b8ll?= , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-spi@vger.kernel.org References: <20210716135441.3235863-1-martin@geanix.com> <20210716135441.3235863-3-martin@geanix.com> From: Tom Rix Message-ID: Date: Fri, 16 Jul 2021 13:44:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210716135441.3235863-3-martin@geanix.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 7/16/21 6:54 AM, Martin Hundebøll wrote: > From: Martin Hundebøll > > The Max10 BMC on the Silicom n5010 PAC is slightly different than the > existing BMCs, so use a dedicated feature revision detect it. > > Signed-off-by: Martin Hundebøll > Reviewed-by: Moritz Fischer > --- > > Changes since v4: > * Moved spi board_info structure from global/static scope > to function/stack scope > > Changes since v3: > * Changed "BMC's" to "BMCs" > * Added Moritz' Reviewed-by > > Changes since v2: > * None > > Changes since v1: > * use feature revision from struct dfl_device instead of reading it > from io-mem > > drivers/spi/spi-altera-dfl.c | 21 ++++++++++++--------- > 1 file changed, 12 insertions(+), 9 deletions(-) > > diff --git a/drivers/spi/spi-altera-dfl.c b/drivers/spi/spi-altera-dfl.c > index 39a3e1a032e0..44fc9ee13fc7 100644 > --- a/drivers/spi/spi-altera-dfl.c > +++ b/drivers/spi/spi-altera-dfl.c > @@ -104,13 +104,6 @@ static const struct regmap_config indirect_regbus_cfg = { > .reg_read = indirect_bus_reg_read, > }; > > -static struct spi_board_info m10_bmc_info = { > - .modalias = "m10-d5005", > - .max_speed_hz = 12500000, > - .bus_num = 0, > - .chip_select = 0, > -}; > - > static void config_spi_master(void __iomem *base, struct spi_master *master) > { > u64 v; > @@ -130,6 +123,7 @@ static void config_spi_master(void __iomem *base, struct spi_master *master) > > static int dfl_spi_altera_probe(struct dfl_device *dfl_dev) > { > + struct spi_board_info board_info = { 0 }; > struct device *dev = &dfl_dev->dev; > struct spi_master *master; > struct altera_spi *hw; > @@ -170,9 +164,18 @@ static int dfl_spi_altera_probe(struct dfl_device *dfl_dev) > goto exit; > } > > - if (!spi_new_device(master, &m10_bmc_info)) { > + if (dfl_dev->revision == FME_FEATURE_REV_MAX10_SPI_N5010) > + strscpy(board_info.modalias, "m10-n5010", SPI_NAME_SIZE); > + else > + strscpy(board_info.modalias, "m10-d5005", SPI_NAME_SIZE); > + > + board_info.max_speed_hz = 12500000; > + board_info.bus_num = 0; > + board_info.chip_select = 0; > + > + if (!spi_new_device(master, &board_info)) { > dev_err(dev, "%s failed to create SPI device: %s\n", > - __func__, m10_bmc_info.modalias); > + __func__, board_info.modalias); > } > Looks good to me. Reviewed-by: Tom Rix > return 0;