linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Qing Zhang <zhangqing@loongson.cn>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-spi@vger.kernel.org, Huacai Chen <chenhc@lemote.com>,
	devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
	linux-kernel@vger.kernel.org, gaojuxin@loongson.cn,
	yangtiezhu@loongson.cn
Subject: Re: [PATCH v2 3/4] MIPS: Loongson64: DTS: Add SPI support to LS7A
Date: Tue, 8 Dec 2020 16:15:43 +0800	[thread overview]
Message-ID: <c5a15af9-3eae-6141-2087-4f4394fae08b@flygoat.com> (raw)
In-Reply-To: <1607413467-17698-3-git-send-email-zhangqing@loongson.cn>


在 2020/12/8 15:44, Qing Zhang 写道:
> add spi and amd node support.

Hi Qing,


Thanks for your patch.

What is AMD node?

Also given that different boards may have different flash, is it a wise

idea to hardcode here?

Thanks.

- Jiaxun


>
> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> ---
>
> v2:
> - Add spi about pci device DT
> ---
>   arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
>
> diff --git a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> index f99a7a1..ab8836b 100644
> --- a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> +++ b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> @@ -405,6 +405,26 @@
>   				interrupt-map-mask = <0 0 0 0>;
>   				interrupt-map = <0 0 0 0 &pic 39 IRQ_TYPE_LEVEL_HIGH>;
>   			};
> +
> +			spi@16,0 {
> +				compatible = "pci0014,7a0b.0",
> +						"pci0014,7a0b",
> +						"pciclass088000",
> +						"pciclass0880";
> +
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				reg = <0xb000 0x0 0x0 0x0 0x0>;
> +				num-chipselects = <0>;
> +				spiflash: s25fl016k@0 {
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +				compatible ="spansion,s25fl016k","jedec,spi-nor";
> +				spi-max-frequency=<50000000>;
> +				reg=<0>;
> +				};
> +			};
>   		};
>   
>   		isa {

  reply	other threads:[~2020-12-08  8:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08  7:44 [PATCH v2 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support Qing Zhang
2020-12-08  7:44 ` [PATCH v2 2/4] spi: Add devicetree bindings documentation for Loongson SPI Qing Zhang
2020-12-08  7:49   ` Jiaxun Yang
2020-12-08  8:40   ` Sergei Shtylyov
2020-12-08 10:47     ` zhangqing
2020-12-08 13:58       ` Mark Brown
2020-12-09  1:21         ` zhangqing
2020-12-08 14:48       ` Sergei Shtylyov
2020-12-09  1:16         ` zhangqing
2020-12-08  7:44 ` [PATCH v2 3/4] MIPS: Loongson64: DTS: Add SPI support to LS7A Qing Zhang
2020-12-08  8:15   ` Jiaxun Yang [this message]
2020-12-08  7:44 ` [PATCH v2 4/4] MIPS: Loongson: Enable Loongson LS7A SPI in loongson3_defconfig Qing Zhang
2020-12-08 12:26 ` [PATCH v2 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support kernel test robot
2020-12-08 13:56 ` Mark Brown
2020-12-09  7:24   ` zhangqing
2020-12-09 11:59     ` Mark Brown
2020-12-08 21:36 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5a15af9-3eae-6141-2087-4f4394fae08b@flygoat.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=broonie@kernel.org \
    --cc=chenhc@lemote.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gaojuxin@loongson.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=yangtiezhu@loongson.cn \
    --cc=zhangqing@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).