From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Behme Dirk (CM/ESO2)" <dirk.behme@de.bosch.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Mason Yang <masonccyang@mxic.com.tw>,
linux-spi@vger.kernel.org,
Chris Brandt <chris.brandt@renesas.com>,
linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH RFC 2/2] memory: add Renesas RPC-IF driver
Date: Thu, 27 Feb 2020 23:32:07 +0300 [thread overview]
Message-ID: <cc60b321-9040-0962-e955-7212689d9a4a@cogentembedded.com> (raw)
In-Reply-To: <b7d64c11-473c-e703-0e5e-55b909861175@de.bosch.com>
Hello!
On 02/26/2020 12:54 PM, Behme Dirk (CM/ESO2) wrote:
>>>>>>> From d72b805cc461ab1e9747c973e9be84e7abb8f828 Mon Sep 17 00:00:00 2001
>>>>>>> From: Dirk Behme <dirk.behme@de.bosch.com>
>>>>>>> Date: Tue, 4 Feb 2020 08:39:31 +0100
>>>>>>> Subject: [PATCH] memory: renesas-rpc-if: Correct the STRTIM and some other
>>>>>>> clean up
>>>>>>>
>>>>>>> This is required to make the driver work correctly in my M3 environment.
>>>>>>>
>>>>>>> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
>>>>>>> ---
>>>>>>> drivers/memory/renesas-rpc-if.c | 42 ++++++++++++++++++++-------------
>>>>>>> 1 file changed, 25 insertions(+), 17 deletions(-)
>>>>>>>
>>>>>>> diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
>>>>>>> index 04be92b64bfa..f4356b066384 100644
>>>>>>> --- a/drivers/memory/renesas-rpc-if.c
>>>>>>> +++ b/drivers/memory/renesas-rpc-if.c
>>>>>> [...]
>>>>>>> @@ -513,19 +525,15 @@ ssize_t rpcif_dirmap_read(struct rpcif *rpc, u64 offs, size_t len, void *buf)
>>>>>>> pm_runtime_get_sync(rpc->dev);
>>>>>>>
>>>>>>> regmap_update_bits(rpc->regmap, RPCIF_CMNCR, RPCIF_CMNCR_MD, 0);
>>>>>>> - regmap_write(rpc->regmap, RPCIF_DRCR,
>>>>>>> - RPCIF_DRCR_RBURST(32) | RPCIF_DRCR_RBE);
>>>>>>> - regmap_write(rpc->regmap, RPCIF_DRCMR, rpc->command);
>>>>>>> - regmap_write(rpc->regmap, RPCIF_DREAR,
>>>>>>> - RPCIF_DREAR_EAV(offs >> 25) | RPCIF_DREAR_EAC(1));
>>>>>>> - regmap_write(rpc->regmap, RPCIF_DROPR, rpc->option);
>>>>>>> - regmap_write(rpc->regmap, RPCIF_DRENR,
>>>>>>> - rpc->enable & ~RPCIF_SMENR_SPIDE(0xF));
>>>>>>> - regmap_write(rpc->regmap, RPCIF_DRDMCR, rpc->dummy);
>>>>>>> - regmap_write(rpc->regmap, RPCIF_DRDRENR, rpc->ddr);
>>>>>>
>>>>>> The driver somehow works only with this left in place (with 2 bytes eaten
>>>>>> as before), otherwise all the flash reads all 0xff (via dirmap).
>>>>>
>>>>>
>>>>> Do you boot from hyperflash?
>>>>
>>>> No, I have arewto say 'cpld write 30 1' in U-Boot before a boot a kernel.
>>
>> s/arewto/to/. :-)
>>
>>>> Normally, the V3x Starter Kit boards are wired for the QSPI flash chips.
>>>>
>>>>> The system I'm using for testing boots from hyperflash. So most probably all registers
>>>>> I don't touch in the driver are put into a reasonable state by the boot code, already.
>>>>> If you don't boot from hyperflash, that at least would explain our different behavior.
>>>>
>>>> Yes. Mind dumping the registers and sending to me?
>>>
>>> Using the attached debug patch (0001-memory-renesas-rpc-if-DEBUG-Dump-register-
>>> content.patch) on a r8a7796 system booting from Hyperflash with above register
>> dropping reverted (i.e. including touching these registers) I get
>>>
>>> Before:
>>> RPCIF_DRCR: 0x00000000
>>> RPCIF_DRCMR: 0x00a00000
>>> RPCIF_DREAR: 0x00000000
>>> RPCIF_DROPR: 0x00000000
>>> RPCIF_DRENR: 0xa222d400
>>> RPCIF_DRDMCR: 0x0000000e
>>> RPCIF_DRDRENR: 0x00005101
>>>
>>> After:
>>> RPCIF_DRCR: 0x001f0100
>>> RPCIF_DRCMR: 0x00a00000
>>> RPCIF_DREAR: 0x00010001
>>> RPCIF_DROPR: 0x00000000
>>> RPCIF_DRENR: 0xa202d400
>>> RPCIF_DRDMCR: 0x0000000e
>>> RPCIF_DRDRENR: 0x00005101
>>>
>>> Comparing that, just 3 registers are different between my working version ("Before") and the version which shows the 2-byte offset ("After"): RPCIF_DRCR, RPCIF_DREAR and RPCIF_DRENR. With try & error, at least in my setup, I was able to reduce this to just RPCIF_DRCR. Dropping the burst mode I was able to 'fix' the two byte offset issue.
>>
>> ACK! Thanks a lot for finding it! :-)
>> That's what I get on the first dirmap read:
>>
>> Before:
>> RPCIF_CMNCR: 0x81fff301
>> RPCIF_DRCR: 0x00000000
>> RPCIF_DRCMR: 0x00030000
>> RPCIF_DREAR: 0x00000000
>> RPCIF_DROPR: 0x00000000
>> RPCIF_DRENR: 0x00004700
>> RPCIF_DRDMCR: 0x00000000
>> RPCIF_DRDRENR: 0x00000000
>>
>> After:
>> RPCIF_CMNCR: 0x01fff301
>> RPCIF_DRCR: 0x001f0100
>> RPCIF_DRCMR: 0x00800000
>> RPCIF_DREAR: 0x00000001
>> RPCIF_DROPR: 0x00000000
>> RPCIF_DRENR: 0xa202d400
>> RPCIF_DRDMCR: 0x0000000e
>> RPCIF_DRDRENR: 0x00005101
>>
>>> Do you like to give the attached 0001-memory-renesas-rpc-if-Don-t-use-burst-mode-on-read.patch a try in your setup?
>>
>> Works like charm! :-)
>
>
> Good news, thanks! :)
>
>
>> Unfortunately, the SPI dirmap and/or writes are still broken.
>
>
> I'm unsure about which function we are talking for "SPI dirmap"?
The same, rpcif_dirmap_read(). I'm now thinking it works correctly, it's just
the writes that are borked.
> Regarding writes, in rpcif_io_xfer() in RPCIF_DATA_IN we have an additional place where burst mode is enabled:
This works around the hardware bug where the SPI NOR RDID command's data bytes get
spoiled, leading to unrecognized flash chip. Well, there's a comment before this *if*.
> if (!(smenr & RPCIF_SMENR_ADE(0xf)) && rpc->dirmap) {
> ...
> regmap_write(rpc->regmap, RPCIF_DRCR,
> RPCIF_DRCR_RBURST(32) | RPCIF_DRCR_RBE);
> ...
>
> Maybe it's worth a try to replace this by just 0, as well:
>
> regmap_write(rpc->regmap, RPCIF_DRCR, 0);
I've just tried that, here's the result:
spi-nor spi0.0: unrecognized JEDEC id bytes: 01 01 01 01 01 01
(and the flash doesn't get registered).
> But of course, this is guessing, as I'm not sure if this
>
> if (!(smenr & RPCIF_SMENR_ADE(0xf)) && rpc->dirmap) {
>
> path is taken, at all?
It's taken but only with SPI NOR.
> Or even better, if you could adapt the "before / after" debug patch to the path which are still not working for you and share it and the results, we could compare it with my setup, too :)
I'll try doing that tomorrow...
> Dirk
MBR, Sergei
next prev parent reply other threads:[~2020-02-27 20:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 19:34 [PATCH RFC 0/2] Add Renesas RPC-IF support Sergei Shtylyov
2019-12-10 19:37 ` [PATCH RFC 1/2] dt-bindings: memory: document Renesas RPC-IF bindings Sergei Shtylyov
2019-12-19 20:38 ` Rob Herring
2019-12-10 19:39 ` [PATCH RFC 2/2] memory: add Renesas RPC-IF driver Sergei Shtylyov
2019-12-11 9:58 ` Philipp Zabel
2020-02-10 10:21 ` Behme Dirk (CM/ESO2)
[not found] ` <5760bcdb-e44b-6f18-7262-9526684e5780-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2020-02-22 20:42 ` Sergei Shtylyov
[not found] ` <5603f393-554d-e2a8-c2d8-6bafc20f4169-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2020-02-24 5:46 ` Behme Dirk (CM/ESO2)
[not found] ` <cba1e2ec-4896-23ef-ef7b-0f80d4310127-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2020-02-24 17:28 ` Chris Brandt
2020-02-24 18:59 ` Sergei Shtylyov
2020-02-25 9:33 ` Behme Dirk (CM/ESO2)
[not found] ` <3a182ac7-8d41-cdc7-2b87-7c503f68a426-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2020-02-25 20:41 ` Sergei Shtylyov
[not found] ` <f21a9444-9541-6558-f5f5-ca0b733768ff-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2020-02-26 9:54 ` Behme Dirk (CM/ESO2)
2020-02-27 20:32 ` Sergei Shtylyov [this message]
2019-12-11 14:33 ` [PATCH RFC 0/2] Add Renesas RPC-IF support Chris Brandt
2019-12-11 16:08 ` Sergei Shtylyov
2019-12-11 16:20 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc60b321-9040-0962-e955-7212689d9a4a@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=masonccyang@mxic.com.tw \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).