From: Mark Brown <broonie@kernel.org>
To: Harald Mommer <harald.mommer@opensynergy.com>
Cc: Haixu Cui <quic_haixcui@quicinc.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_ztu@quicinc.com, Matti Moell <Matti.Moell@opensynergy.com>,
Mikhail Golubev <Mikhail.Golubev@opensynergy.com>
Subject: Re: [PATCH v2 3/3] virtio-spi: Add virtio SPI driver.
Date: Tue, 19 Mar 2024 17:11:09 +0000 [thread overview]
Message-ID: <cfb5092b-ad8f-4364-8655-8f797c428b25@sirena.org.uk> (raw)
In-Reply-To: <5dedcd26-ed59-415f-b978-87a546a0816d@opensynergy.com>
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On Tue, Mar 19, 2024 at 04:05:55PM +0100, Harald Mommer wrote:
> On 18.03.24 10:39, Haixu Cui wrote:
> Looks in my setup like this:
>
> virtio_mmio@4b013000 {
> compatible = "virtio,mmio";
> reg = <0x0 0x4b013000 0x0 0x1000>;
> /* GIC_SPI = 0, IRQ_TYPE_LEVEL_HIGH = 4 */
> interrupts = <0 497 4>;
> spi,bus-num = <1234>; /* <<<=== This here has been added */
> };
>
> The "spi,bus-num" is missing in your setup so you use the default of 0.
The default should be dynamic assignment, why would you need a fixed bus
number?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-19 17:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 15:43 [PATCH v2 0/3] Virtio SPI Linux driver Harald Mommer
2024-03-04 15:43 ` [PATCH v2 1/3] virtio: Add ID for virtio SPI Harald Mommer
2024-03-04 15:43 ` [PATCH v2 2/3] virtio-spi: Add virtio-spi.h Harald Mommer
2024-03-04 15:43 ` [PATCH v2 3/3] virtio-spi: Add virtio SPI driver Harald Mommer
2024-03-14 9:17 ` Haixu Cui
2024-03-14 13:35 ` Mark Brown
2024-03-18 9:39 ` Haixu Cui
2024-03-19 15:05 ` Harald Mommer
2024-03-19 17:11 ` Mark Brown [this message]
2024-03-20 3:12 ` Viresh Kumar
2024-03-26 9:26 ` Haixu Cui
2024-03-26 11:19 ` Harald Mommer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfb5092b-ad8f-4364-8655-8f797c428b25@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Matti.Moell@opensynergy.com \
--cc=Mikhail.Golubev@opensynergy.com \
--cc=harald.mommer@opensynergy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=quic_haixcui@quicinc.com \
--cc=quic_ztu@quicinc.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).