From: Hans de Goede <hdegoede@redhat.com>
To: Stefan Binding <sbinding@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Mark Gross <markgross@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH v4 0/9] Support Spi in i2c-multi-instantiate driver
Date: Thu, 20 Jan 2022 17:34:28 +0100 [thread overview]
Message-ID: <d6958153-7747-bc4b-2de0-57aa3226d984@redhat.com> (raw)
In-Reply-To: <20220120134326.5295-1-sbinding@opensource.cirrus.com>
Hi Mark,
On 1/20/22 14:43, Stefan Binding wrote:
> Add support for SPI bus in the i2c-multi-instantiate driver as
> upcoming laptops will need to multi instantiate SPI devices from
> a single device node, which has multiple SpiSerialBus entries at
> the ACPI table.
>
> With the new SPI support, i2c-multi-instantiate becomes
> bus-multi-instantiate and is moved to the ACPI folder.
>
> The intention is to support the SPI bus by re-using the current
> I2C multi instantiate, instead of creating a new SPI multi
> instantiate, to make it possible for peripherals that can be
> controlled by I2C or SPI to have the same HID at the ACPI table.
>
> The new driver (Bus multi instantiate, bmi) checks for the
> hard-coded bus type and returns -ENODEV in case of zero devices
> found for that bus. In the case of automatic bus detection,
> the driver will give preference to I2C.
>
> The expectation is for a device node in the ACPI table to have
> multiple I2cSerialBus only or multiple SpiSerialBus only, not
> a mix of both; and for the case where there are both entries in
> one device node, only the I2C ones would be probed.
>
> This new bus multi instantiate will be used in CS35L41 HDA new
> driver.
Mark, since most of my review remarks are small(ish) I expect
the next version of this (except patch 8/9) to be ready for
merging.
I can either merge all patches on top of 5.17-rc1 once released;
and provide an immutable-branch for you to merge for the SPI
bits; or you can merge patches 1-4 (the SPI patches) and then
send me a pull-req for an immutable-branch with those 4,
so that I can merge that and then the rest on top.
Mark, please let me know how you want to proceed with merging this.
Regards,
Hans
>
> Changes since V2:
> - Moved bus-multi-instantiate back into platform/x86
>
> Lucas Tanure (4):
> platform/x86: i2c-multi-instantiate: Rename it for a generic bus
> driver name
> platform/x86: bus-multi-instantiate: Reorganize I2C functions
> ALSA: hda/realtek: Add support for HP Laptops
> ACPI / scan: Create platform device for CS35L41
>
> Stefan Binding (5):
> spi: Make spi_alloc_device and spi_add_device public again
> spi: Create helper API to lookup ACPI info for spi device
> spi: Support selection of the index of the ACPI Spi Resource before
> alloc
> spi: Add API to count spi acpi resources
> platform/x86: bus-multi-instantiate: Add SPI support
>
> MAINTAINERS | 4 +-
> drivers/acpi/scan.c | 16 +-
> drivers/platform/x86/Kconfig | 14 +-
> drivers/platform/x86/Makefile | 2 +-
> drivers/platform/x86/bus-multi-instantiate.c | 369 +++++++++++++++++++
> drivers/platform/x86/i2c-multi-instantiate.c | 174 ---------
> drivers/spi/spi.c | 142 ++++++-
> include/linux/spi/spi.h | 32 ++
> sound/pci/hda/patch_realtek.c | 43 ++-
> 9 files changed, 588 insertions(+), 208 deletions(-)
> create mode 100644 drivers/platform/x86/bus-multi-instantiate.c
> delete mode 100644 drivers/platform/x86/i2c-multi-instantiate.c
>
prev parent reply other threads:[~2022-01-20 16:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 13:43 [PATCH v4 0/9] Support Spi in i2c-multi-instantiate driver Stefan Binding
2022-01-20 13:43 ` [PATCH v4 1/9] spi: Make spi_alloc_device and spi_add_device public again Stefan Binding
2022-01-20 14:39 ` Hans de Goede
2022-01-20 13:43 ` [PATCH v4 2/9] spi: Create helper API to lookup ACPI info for spi device Stefan Binding
2022-01-20 14:37 ` Hans de Goede
2022-01-20 13:43 ` [PATCH v4 3/9] spi: Support selection of the index of the ACPI Spi Resource before alloc Stefan Binding
2022-01-20 15:03 ` Hans de Goede
2022-01-20 13:43 ` [PATCH v4 4/9] spi: Add API to count spi acpi resources Stefan Binding
2022-01-20 14:39 ` Hans de Goede
2022-01-20 15:04 ` Hans de Goede
2022-01-20 13:43 ` [PATCH v4 5/9] platform/x86: i2c-multi-instantiate: Rename it for a generic bus driver name Stefan Binding
2022-01-20 15:05 ` Hans de Goede
2022-01-20 18:34 ` Rafael J. Wysocki
2022-01-20 18:39 ` Hans de Goede
2022-01-20 13:43 ` [PATCH v4 6/9] platform/x86: bus-multi-instantiate: Reorganize I2C functions Stefan Binding
2022-01-20 15:13 ` Hans de Goede
2022-01-20 16:03 ` Hans de Goede
2022-01-20 16:17 ` Hans de Goede
2022-01-20 13:43 ` [PATCH v4 7/9] platform/x86: bus-multi-instantiate: Add SPI support Stefan Binding
2022-01-20 16:30 ` Hans de Goede
2022-01-20 13:43 ` [PATCH v4 8/9] ALSA: hda/realtek: Add support for HP Laptops Stefan Binding
2022-01-20 15:27 ` Takashi Iwai
2022-01-21 14:32 ` Stefan Binding
2022-01-21 14:39 ` Takashi Iwai
2022-01-20 13:43 ` [PATCH v4 9/9] ACPI / scan: Create platform device for CS35L41 Stefan Binding
2022-01-20 16:31 ` Hans de Goede
2022-01-20 16:34 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6958153-7747-bc4b-2de0-57aa3226d984@redhat.com \
--to=hdegoede@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sbinding@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).