From: John Garry <john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] spi: Remove CONFIG_ prefix from Kconfig select
Date: Thu, 5 Mar 2020 15:53:57 +0000 [thread overview]
Message-ID: <e265e7df-fd8c-691f-389a-c0e0e377ed9e@huawei.com> (raw)
In-Reply-To: <f8ac6b32a29b9a05b58a7e58ffe8b780642abbf1.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
On 05/03/2020 15:15, Joe Perches wrote:
> commit a2ca53b52e00 ("spi: Add HiSilicon v3xx SPI NOR flash
> controller driver") likely inadvertently used a select statement
> with a CONFIG_ prefix, remove the prefix.
>
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
It's a pity checkpatch can't pick this stuff up...
The select is just for enabling the driver of a slave driver, so should
not cause any build issues when not enabled. thanks
FWIW,
Acked-by: John Garry <john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> ---
> drivers/spi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 82177d..2dc7bd 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -292,7 +292,7 @@ config SPI_HISI_SFC_V3XX
> tristate "HiSilicon SPI-NOR Flash Controller for Hi16XX chipsets"
> depends on (ARM64 && ACPI) || COMPILE_TEST
> depends on HAS_IOMEM
> - select CONFIG_MTD_SPI_NOR
> + select MTD_SPI_NOR
> help
> This enables support for HiSilicon v3xx SPI-NOR flash controller
> found in hi16xx chipsets.
>
>
> .
>
next prev parent reply other threads:[~2020-03-05 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 15:15 [PATCH] spi: Remove CONFIG_ prefix from Kconfig select Joe Perches
[not found] ` <f8ac6b32a29b9a05b58a7e58ffe8b780642abbf1.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2020-03-05 15:53 ` John Garry [this message]
[not found] ` <e265e7df-fd8c-691f-389a-c0e0e377ed9e-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2020-03-05 16:01 ` Joe Perches
[not found] ` <84f8504924380fc6380216d03d28a2285e3d106e.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2020-03-05 16:20 ` John Garry
[not found] ` <55edba5c-78d6-12e2-eff6-f16c204badee-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2020-03-05 16:21 ` Randy Dunlap
[not found] ` <15ad3c68-4e67-0c92-a0e1-c62861673561-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2020-03-05 16:38 ` Joe Perches
2020-03-06 15:19 ` Applied "spi: Remove CONFIG_ prefix from Kconfig select" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e265e7df-fd8c-691f-389a-c0e0e377ed9e@huawei.com \
--to=john.garry-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).