From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Garry Subject: Re: [PATCH] spi: Remove CONFIG_ prefix from Kconfig select Date: Thu, 5 Mar 2020 15:53:57 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: Mark Brown , linux-spi , LKML To: Joe Perches Return-path: In-Reply-To: Content-Language: en-US Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 05/03/2020 15:15, Joe Perches wrote: > commit a2ca53b52e00 ("spi: Add HiSilicon v3xx SPI NOR flash > controller driver") likely inadvertently used a select statement > with a CONFIG_ prefix, remove the prefix. > > Signed-off-by: Joe Perches It's a pity checkpatch can't pick this stuff up... The select is just for enabling the driver of a slave driver, so should not cause any build issues when not enabled. thanks FWIW, Acked-by: John Garry > --- > drivers/spi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index 82177d..2dc7bd 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -292,7 +292,7 @@ config SPI_HISI_SFC_V3XX > tristate "HiSilicon SPI-NOR Flash Controller for Hi16XX chipsets" > depends on (ARM64 && ACPI) || COMPILE_TEST > depends on HAS_IOMEM > - select CONFIG_MTD_SPI_NOR > + select MTD_SPI_NOR > help > This enables support for HiSilicon v3xx SPI-NOR flash controller > found in hi16xx chipsets. > > > . >