From: Johan Jonker <jbx6244@gmail.com>
To: Rob Herring <robh@kernel.org>, Jon Lin <jon.lin@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org, heiko@sntech.de,
linux-arm-kernel@lists.infradead.org, broonie@kernel.org,
devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v6 1/6] dt-bindings: spi: spi-rockchip: add description for rv1126
Date: Thu, 10 Jun 2021 21:38:06 +0200 [thread overview]
Message-ID: <e71e9bca-4c30-d155-2beb-cb85a7b3106a@gmail.com> (raw)
In-Reply-To: <20210610160634.GA1894512@robh.at.kernel.org>
Hi Rob,
Similar to the Rockchip SFC discussion this compatible does currently
not add any data or difference to the driver. Therefore a simple
fallback string will do for now. That in the past that was not strictly
enforced, so be it.
Could you have a look at it?
Kind regards,
Johan Jonker
https://lore.kernel.org/linux-rockchip/20210607063448.29589-1-jon.lin@rock-chips.com/T/#e202225dbe50829069becd2915267124f379bf2fe
- rockchip,rk3368-spi
- rockchip,rk3399-spi
- rockchip,rv1126-spi
- const: rockchip,rk3066-spi
On 6/10/21 6:06 PM, Rob Herring wrote:
> On Mon, 07 Jun 2021 19:18:32 +0800, Jon Lin wrote:
>> The description below will be used for rv1126.dtsi or compatible one in
>> the future
>>
>> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
>> ---
>>
>> Changes in v6:
>> - Consider to compatibility, the "rockchip,rk3568-spi" is removed in
>> Series-changes v5, so the commit massage should also remove the
>> corresponding information
>>
>> Changes in v5:
>> - Change to leave one compatible id rv1126, and rk3568 is compatible
>> with rv1126
>>
>> Changes in v4:
>> - Adjust the order patches
>> - Simply commit massage like redundancy "application" content
>>
>> Changes in v3:
>> - Fix compile error which is find by Sascha in [v2,2/8]
>>
>> Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>
> Acked-by: Rob Herring <robh@kernel.org>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
next prev parent reply other threads:[~2021-06-10 19:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 11:18 [PATCH v6 0/6] Support ROCKCHIP SPI new feature Jon Lin
2021-06-07 11:18 ` [PATCH v6 1/6] dt-bindings: spi: spi-rockchip: add description for rv1126 Jon Lin
2021-06-10 16:06 ` Rob Herring
2021-06-10 19:38 ` Johan Jonker [this message]
2021-06-07 11:18 ` [PATCH v6 2/6] spi: rockchip: add compatible string " Jon Lin
2021-06-07 11:18 ` [PATCH v6 3/6] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item Jon Lin
2021-06-07 11:18 ` [PATCH v6 4/6] spi: rockchip: Wait for STB status in slave mode tx_xfer Jon Lin
2021-06-07 11:19 ` [PATCH v6 5/6] spi: rockchip: Support cs-gpio Jon Lin
2021-06-07 11:19 ` [PATCH v6 6/6] spi: rockchip: Support SPI_CS_HIGH Jon Lin
2021-06-15 3:26 ` [PATCH v7 0/6] Support ROCKCHIP SPI new feature Jon Lin
2021-06-15 3:26 ` [PATCH v7 1/6] dt-bindings: spi: spi-rockchip: add description for rv1126 Jon Lin
2021-06-16 15:26 ` Rob Herring
2021-06-15 3:26 ` [PATCH v7 2/6] spi: rockchip: add compatible string " Jon Lin
2021-06-15 3:26 ` [PATCH v7 3/6] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item Jon Lin
2021-06-15 3:26 ` [PATCH v7 4/6] spi: rockchip: Wait for STB status in slave mode tx_xfer Jon Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e71e9bca-4c30-d155-2beb-cb85a7b3106a@gmail.com \
--to=jbx6244@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jon.lin@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).