From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH v2 2/3] mtd: m25p80: consider max message size in m25p80_read Date: Fri, 23 Dec 2016 19:53:50 +0100 Message-ID: References: <6c95366c-7fcc-ef4c-033a-f9f6e152a669@gmail.com> <20160816164204.GV9347@sirena.org.uk> <2e31fbe7-bbc7-8fed-ccbf-dd9ae4d220e1@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , MTD Maling List To: Cyrille Pitchen , Heiner Kallweit , Mark Brown , Brian Norris Return-path: In-Reply-To: <2e31fbe7-bbc7-8fed-ccbf-dd9ae4d220e1-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 12/23/2016 04:33 PM, Cyrille Pitchen wrote: > Le 17/08/2016 à 21:09, Heiner Kallweit a écrit : >> Consider a message size limit when calculating the maximum amount >> of data that can be read. >> >> Signed-off-by: Heiner Kallweit > > Applied to git://github.com/spi-nor/linux.git Is that the concensus now that we should fix controller crappiness on driver level ? Or did I miss the point of this patch ? > Thanks! > >> --- >> v2: >> - use the new function spi_max_message_size >> --- >> drivers/mtd/devices/m25p80.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c >> index 9cf7fcd..16a7df2 100644 >> --- a/drivers/mtd/devices/m25p80.c >> +++ b/drivers/mtd/devices/m25p80.c >> @@ -172,7 +172,8 @@ static ssize_t m25p80_read(struct spi_nor *nor, loff_t from, size_t len, >> >> t[1].rx_buf = buf; >> t[1].rx_nbits = m25p80_rx_nbits(nor); >> - t[1].len = min(len, spi_max_transfer_size(spi)); >> + t[1].len = min3(len, spi_max_transfer_size(spi), >> + spi_max_message_size(spi) - t[0].len); >> spi_message_add_tail(&t[1], &m); >> >> ret = spi_sync(spi, &m); >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-spi" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html