From: Phil Reid <preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
To: Andy Shevchenko
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
kernel-NoMTM8u0nx3R7s880joybQ@public.gmane.org,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 1/1] spi: dw: Make debugfs name unique between instances
Date: Wed, 4 Jan 2017 10:21:23 +0800 [thread overview]
Message-ID: <ea4998f7-e55c-884e-cb4d-5533c7104dd7@electromag.com.au> (raw)
In-Reply-To: <CAHp75VfeX+9b2bEt9VdNrOX9+jbqfvXx8rk=K2FJsoghRoxQJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
G'day Andy,
On 4/01/2017 07:05, Andy Shevchenko wrote:
> On Wed, Jan 4, 2017 at 1:02 AM, Andy Shevchenko
> <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On Tue, Jan 3, 2017 at 6:54 AM, Phil Reid <preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org> wrote:
>>> Some system have multiple dw devices. Currently the driver uses a
>>> fixed name for the debugfs dir. Append bus_num to the debugfs dir
>>> name to make it unique.
>>>
>>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Ah, hold on.
> dws->name is exactly what you are trying to re-invent here. Just use
> it directly.
>
I did try that initially.
However when I used that they where all named dw_spi65535.
This seems to be because bus_num is set to -1 ion the call to dw_spi_add_host.
Which results in dynamic bus_num assignment in the call to devm_spi_register_master.
Moving 'snprintf(dws->name, sizeof(dws->name), "dw_spi%d", dws->bus_num);' to after
devm_spi_register_master results in a warning being emitting when request_irq is called
about an emit string at :
WARNING: CPU: 0 PID: 1 at fs/proc/generic.c:369 __proc_create+0x1e8/0x1f0
cat /proc/interrupts currently also shows dw_spi65535
Rewrite dws->name after devm_spi_register_master is called fixes /proc/interrupts
And it could then be used in debugfs.
But does not fix the filename in /proc/irq/<num>/dw_spi65535
I couldn't see a safe workaround with dws->name
Unless we can move the request_irq to after devm_spi_register_master
Thoughts?
>
>>
>>> Signed-off-by: Phil Reid <preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
>>> ---
>>>
>>> Notes:
>>> Changes from v1:
>>> - Reduce buffer size to 32.
>>> - Use bus_num instead of device name.
>>>
>>> drivers/spi/spi-dw.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c
>>> index 27960e4..77439ac 100644
>>> --- a/drivers/spi/spi-dw.c
>>> +++ b/drivers/spi/spi-dw.c
>>> @@ -107,7 +107,10 @@ static ssize_t dw_spi_show_regs(struct file *file, char __user *user_buf,
>>>
>>> static int dw_spi_debugfs_init(struct dw_spi *dws)
>>> {
>>> - dws->debugfs = debugfs_create_dir("dw_spi", NULL);
>>> + char name[32];
>>> +
>>> + snprintf(name, 32, "dw_spi%d", dws->master->bus_num);
>>> + dws->debugfs = debugfs_create_dir(name, NULL);
>>> if (!dws->debugfs)
>>> return -ENOMEM;
>>>
>>> --
>>> 1.8.3.1
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-spi" in
>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
>
>
>
--
Regards
Phil Reid
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-04 2:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 4:54 [PATCH v2 1/1] spi: dw: Make debugfs name unique between instances Phil Reid
[not found] ` <1483419249-88956-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-01-03 23:02 ` Andy Shevchenko
[not found] ` <CAHp75Vc=h1eepd3DYEiSxP_vG1CS+FyKijmEYtw8Td7dj_VZOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-03 23:05 ` Andy Shevchenko
[not found] ` <CAHp75VfeX+9b2bEt9VdNrOX9+jbqfvXx8rk=K2FJsoghRoxQJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-04 2:21 ` Phil Reid [this message]
[not found] ` <ea4998f7-e55c-884e-cb4d-5533c7104dd7-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-01-04 9:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea4998f7-e55c-884e-cb4d-5533c7104dd7@electromag.com.au \
--to=preid-qgqnfa1juf/o2in0hyhwsidd74u8msao@public.gmane.org \
--cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kernel-NoMTM8u0nx3R7s880joybQ@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).