From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Grant Likely" Subject: Re: [PATCH 3/4] spi: Add OF binding support for SPI busses Date: Sat, 24 May 2008 11:33:35 -0600 Message-ID: References: <20080516193054.28030.35126.stgit@trillian.secretlab.ca> <20080516193613.28030.13950.stgit@trillian.secretlab.ca> <20080521151928.GA28857@polina.dev.rtsoft.ru> <200805221905.32288.david-b@pacbell.net> <48384D13.6010608@scram.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: David Brownell , linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, fabrizio.garetto-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Jochen Friedrich" Return-path: In-Reply-To: <48384D13.6010608-NIgtFMG+Po8@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Sat, May 24, 2008 at 11:14 AM, Jochen Friedrich wrote: > Grant Likely schrieb: >> On Sat, May 24, 2008 at 12:26 AM, Grant Likely >> wrote: >>> On Thu, May 22, 2008 at 8:05 PM, David Brownell wrote: >>>> On Wednesday 21 May 2008, Anton Vorontsov wrote: >>>>>> +++ b/drivers/spi/spi_of.c >>>>> I think better placement for this is drivers/of, no? >>>> Yes please. >>> Okay, I wasn't sure. Will do. >> >> I'm having second thoughts about this. I think this code is more SPI >> centric than it is OF centric. ie. it is usable by all spi masters in >> an OF enabled system, but it is not usable by all OF devices in an SPI >> enabled system. Or, in other words; it adds OF support to SPI, not >> the other way around. I think drivers/spi is the right place for this >> to live. > > Isn't the same true for drivers/of/gpio.c or drivers/of/of_i2c.c, as well? I would argue 'yes!' g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/