archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <>
To: Wolfram Sang <>
	David Brownell <>,,,
Subject: Re: [spi-devel-general] [PATCH v4] powerpc/5200: Add mpc5200-spi (non-PSC) device driver
Date: Fri, 3 Jul 2009 01:01:24 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Jun 18, 2009 at 8:26 AM, Wolfram Sang<> wrote:
>> There used to be a sysfs interface for dumping these, but it was an
>> ugly misuse.  I'd like to leave these in.  I still have the sysfs bits
>> in a private patch and I'm going to rework them for debugfs.
> Okay. Maybe a comment stating the future use will be nice.


>> > But I wonder more about the usage of the SS pin and if this chipsel is needed
>> > at all (sadly I cannot test as I don't have any board with SPI connected to
>> > that device). You define the SS-pin as output, but do not set the SSOE-bit.
>> > More, you use the MODF-feature, so the SS-pin should be defined as input?
>> > According to Table 17.3 in the PM, you have that pin defined as generic purpose
>> > output.
>> That's right.  The SS handling by the SPI device is completely
>> useless, so this driver uses it as a GPIO and asserts it manually.
> That definately needs a comment :D (perhaps with some more details if you know them).
>> The MODF irq is probably irrelevant, but I'd like to leave it in for
>> completeness.
> But it won't work if the pin is set to output, no?


> Are you sure there are no side-effects?

I'm sure.

Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

  reply	other threads:[~2009-07-03  7:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-18  2:55 [PATCH v4] powerpc/5200: Add mpc5200-spi (non-PSC) device driver Grant Likely
2009-06-18  6:58 ` [spi-devel-general] " Wolfram Sang
2009-06-18 13:35   ` Grant Likely
2009-06-18 14:26     ` Wolfram Sang
2009-07-03  7:01       ` Grant Likely [this message]
2009-10-21 13:17 ` Wolfram Sang
2009-10-21 14:45   ` Grant Likely
2009-10-21 17:06     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).