archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <>
Cc: Torsten Fleischer <>,,
Subject: Re: spi_mpc8xxx.c: chip select polarity problem
Date: Thu, 26 Nov 2009 11:50:05 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Nov 26, 2009 at 11:41 AM, Anton Vorontsov
<> wrote:
> On Thu, Nov 26, 2009 at 11:16:34AM -0700, Grant Likely wrote:
> [...]
>> The spi-cs-high property is defined in
>> Documentation/powerpc/dts-bindings/spi-bus.txt, but it definitely was
>> a mistake
> Yup.
>> Currently the spi-cs-high property is parsed in the
>> of_register_spi_devices() function, but the CS polarity needs to be
>> known before registering devices.  It needs to be factored out into
>> another utility function callable by spi bus drivers so that it can
>> get polarity data at probe time.
> Untill we have this, Torsten's patch is a real improvement, and
> works for non-broken hw/fw.
> So I think it should be applied.

I disagree since it only band-aids the problem and uglifies the driver
in the process.  In the immediate term the driver needs to be changed
to read the spi-cs-high property out of the child nodes before
registering the devices.  I'm not going to apply this patch.


Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

  reply	other threads:[~2009-11-26 18:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
     [not found] ` <>
     [not found]   ` <>
     [not found]     ` <>
2009-11-25 22:11       ` spi_mpc8xxx.c: chip select polarity problem Grant Likely
2009-11-26 12:12         ` Anton Vorontsov
2009-11-26 17:27           ` Torsten Fleischer
2009-11-26 18:18             ` Grant Likely
2009-11-26 18:16           ` Grant Likely
2009-11-26 18:41             ` Anton Vorontsov
2009-11-26 18:50               ` Grant Likely [this message]
2009-11-26 19:01                 ` Anton Vorontsov
2009-11-26 19:17                   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).