linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: "Uwe Kleine-König"
	<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	mm-commits-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	daniel-rDUAYElUppE@public.gmane.org,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: + spi-imx-use-platform_driver_probe-as-probe-lives-in-inittext.patch added to -mm tree
Date: Wed, 9 Dec 2009 08:15:20 -0700	[thread overview]
Message-ID: <fa686aa40912090715j7235a722nac10f0dc08554d97@mail.gmail.com> (raw)
In-Reply-To: <20091209074251.GA8136-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

2009/12/9 Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>:
> On Tue, Dec 08, 2009 at 05:34:21PM -0700, Grant Likely wrote:
>> Hi Uwe.
>>
>> On Tue, Dec 8, 2009 at 4:30 PM,  <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:
>> > Subject: spi-imx: use platform_driver_probe as probe lives in .init.text
>> > From: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>> >
>> > Using platform_driver_register with a probe function defined using __init
>> > is wrong.
>> >
>> > This fixes an oops after:
>> >
>> >        cd /sys/bus/platform/drivers/spi_imx
>> >        echo -n spi_imx.0 > unbind
>> >        echo -n spi_imx.0 > bind
>> >
>> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>> > Cc: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
>> > Cc: Daniel Mack <daniel-rDUAYElUppE@public.gmane.org>
>> > Cc: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>> > Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>> > Signed-off-by: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
>> > ---
>> >
>> >  drivers/spi/spi_imx.c |    3 +--
>> >  1 file changed, 1 insertion(+), 2 deletions(-)
>> >
>> > diff -puN drivers/spi/spi_imx.c~spi-imx-use-platform_driver_probe-as-probe-lives-in-inittext drivers/spi/spi_imx.c
>> > --- a/drivers/spi/spi_imx.c~spi-imx-use-platform_driver_probe-as-probe-lives-in-inittext
>> > +++ a/drivers/spi/spi_imx.c
>> > @@ -666,13 +666,12 @@ static struct platform_driver spi_imx_dr
>> >                   .name = DRIVER_NAME,
>> >                   .owner = THIS_MODULE,
>> >                   },
>> > -       .probe = spi_imx_probe,
>> >        .remove = __exit_p(spi_imx_remove),
>>
>> This looks wrong.  Why can't spi_imx_probe and spi_imx_remove be
>> changed to be __devinit and __devexit?
> I don't care much, but I thought this to be in accordance to
>
>        d1e44d9 (SPI driver runtime footprint shrinkage)
>
> (http://git.kernel.org/linus/d1e44d9).  I have a whole bunch of such
> patches and already sent it three times (I think).  There is no
> accordance in the community that one of the two possibilities is better
> than the other.

hmmm.  I don't like the pattern, but I'm not going to reject it out of
hand.  Let me think about it for a bit.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev

       reply	other threads:[~2009-12-09 15:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200912082330.nB8NU1Ud016093@imap1.linux-foundation.org>
     [not found] ` <fa686aa40912081634q22319e2ud67d56f10cfc6c25@mail.gmail.com>
     [not found]   ` <20091209074251.GA8136@pengutronix.de>
     [not found]     ` <20091209074251.GA8136-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-12-09 15:15       ` Grant Likely [this message]
     [not found]         ` <fa686aa40912090715j7235a722nac10f0dc08554d97-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-09 15:23           ` Grant Likely
     [not found]             ` <fa686aa40912090723n6b15dba3p9b63a2f4ae5d9067-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-14 17:57               ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa686aa40912090715j7235a722nac10f0dc08554d97@mail.gmail.com \
    --to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=daniel-rDUAYElUppE@public.gmane.org \
    --cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=mm-commits-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --subject='Re: + spi-imx-use-platform_driver_probe-as-probe-lives-in-inittext.patch added to -mm tree' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).