archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely-s3s/>
To: "Uwe Kleine-König"
	Greg Kroah-Hartman <>,,,
	David Vrabel <>
Subject: Re: + spi-imx-correct-check-for-platform_get_irq-failing.patch added to -mm tree
Date: Wed, 9 Dec 2009 10:23:48 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

2009/12/9 Uwe Kleine-König <>:
> On Wed, Dec 09, 2009 at 08:08:19AM -0700, Grant Likely wrote:
>> >> This changes the old behaviour.  Is that what you intended?  '<= 0' perhaps?
>> > Yes, the old check was wrong.  What if the irq to use is 0?  I thought
>> > the commit log to be understandable.  platform_get_irq returns -ENXIO on
>> > error and an irq number on success.  So 0 has to be interpreted as valid
>> > irq, not an error.
>> 0 is not a valid IRQ
> Hmm, on my x86 I have:
>        $ grep '\<0:' /proc/interrupts
>           0:      24330   IO-APIC-edge      timer
> arm/davinci starts at 0, too.  As does arm/ns9xxx.  arm/pxa seems to
> start at 1.  realview starts at 1, too.  So four out of five make are
> wrong?  Seems like a big area for cleanup.

As discussed on IRC, regardless of some of the core & arch use cases.
As far as drivers are concerned, 0 is not a valid IRQ.  Linus'
comments here were referenced:

The return of -ENXIO was added in commit 305b3228, and it is
definitely in the workaround category.  Damn.  And a quick grep show a
lot of broken drivers because of it.  (variations on the common 'if
(!irq)' pattern abound as well as a large number of the variant 'if
(irq < 0)').

Well.  Though I don't like it, I will take the patch as testing for <=
0 instead of < 0.  At least that doesn't create new situations of 0
being used as a valid IRQ.


Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Return on Information:
Google Enterprise Search pays you back
Get the facts.

  parent reply	other threads:[~2009-12-09 17:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
     [not found] ` <>
     [not found]   ` <>
     [not found]     ` <>
2009-12-09 15:08       ` + spi-imx-correct-check-for-platform_get_irq-failing.patch added to -mm tree Grant Likely
     [not found]         ` <>
2009-12-09 15:32           ` Uwe Kleine-König
     [not found]             ` <>
2009-12-09 17:23               ` Grant Likely [this message]
2009-12-09 17:55             ` Uwe Kleine-König
2009-12-09 18:00               ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \
    --to=grant.likely-s3s/ \
    --cc=akpm-de/ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).