Re: [Uclinux-dist-devel] [PATCH] Clear control bits in drivers/spi/spi_bfin5xx.c as necessary

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Fri, Dec 18, 2009 at 10:34 AM, Mike Frysinger <vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Fri, Dec 18, 2009 at 08:14, Mike Frysinger wrote:
>> On Fri, Dec 18, 2009 at 02:29, James Getzendanner wrote:
>>> From: Andy Getzendanner <james.getzendanner-9geRo0GdX4k6efY3Smnssodd74u8MsAO@public.gmane.org>
>>> The patch also modifies bfin_spi_setup() to
>>> set/clear the SIZE bit as appropriate.
>>
>> ok, but this isnt the place to do it.  the size can be changed on a
>> per-transfer basis.  i have a patch locally to unify the transfer size
>> logic and i'll include this fix in the process.
>
> i lied, this isnt necessary.  it's already handled in the transfer code.
>    cr = (read_CTRL(drv_data) & (~BIT_CTL_TIMOD));
>    cr |= (width << 8);
>    write_CTRL(drv_data, cr);
>
> where width is CFG_SPI_WORDSIZE16 or CFG_SPI_WORDSIZE8 as dictated by
> the transfer.
> -mike

Mike & James,

It's not clear to me from the discussion.  What is the status of this
patch, is it still needed?

also...

On Fri, Dec 18, 2009 at 12:29 AM, James Getzendanner
<James.Getzendanner-9geRo0GdX4k6efY3Smnssodd74u8MsAO@public.gmane.org> wrote:
> --- linux-2.6.32.1/drivers/spi/spi_bfin5xx.c.orig       2009-12-14 12:47:25.000000000 -0500
> +++ linux-2.6.32.1/drivers/spi/spi_bfin5xx.c    2009-12-18 00:27:10.000000000 -0500
> @@ -1051,10 +1051,16 @@ static int bfin_spi_setup(struct spi_dev
>        /* translate common spi framework into our register */
>        if (spi->mode & SPI_CPOL)
>                chip->ctl_reg |= CPOL;
> +       else
> +               chip->ctl_reg &= ~CPOL;
>        if (spi->mode & SPI_CPHA)
>                chip->ctl_reg |= CPHA;
> +       else
> +               chip->ctl_reg &= ~CPHA;
>        if (spi->mode & SPI_LSB_FIRST)
>                chip->ctl_reg |= LSBF;
> +       else
> +               chip->ctl_reg &= ~LSBF;
>        /* we dont support running in slave mode (yet?) */
>        chip->ctl_reg |= MSTR;

chip->ctl_reg &= ~(CPOL | CPHA | LSBF); before the set of if()
statements would be more concise.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev