From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v2] SPI DaVinci: SPI master driver for DaVinci/DA8xx Date: Wed, 20 Jan 2010 13:26:59 -0700 Message-ID: References: <1261000938-1897-1-git-send-email-s-paulraj@ti.com> <878wccqfmp.fsf@deeprootsystems.com> <87iqbgnjpq.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, s-paulraj-l0cyMroinI0@public.gmane.org To: Kevin Hilman Return-path: In-Reply-To: <87iqbgnjpq.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Tue, Jan 5, 2010 at 5:46 PM, Kevin Hilman wrote: > Grant Likely writes: > >> On Tue, Jan 5, 2010 at 4:46 PM, Kevin Hilman >> wrote: >>> s-paulraj-l0cyMroinI0@public.gmane.org writes: >>> >>>> From: Sandeep Paulraj >>>> >>>> This patch adds support for a SPI master driver for the >>>> DaVinci series of SOCs >>>> >>>> Signed-off-by: Sandeep Paulraj >>>> Signed-off-by: Mark A. Greer >>>> Signed-off-by: Philby John >>>> Signed-off-by: Sudhakar Rajashekhara >>> >>> Sandeep, >>> >>> This needs a minor refresh against current Linus tree for the Makefile >>> change. >>> >>> While doing the Makefile addition, it looks like the list is maintained= in >>> alphabetical order. =A0Please add davinci in the right order, and feel = free to >>> add my signoff. >> >> Signed-of-by lines are only for patches that actually pass through >> your hands (ie. you add it yourself when you pick it up and pass it). >> It is not appropriate to add a s-o-b line for someone else. >> "Acked-by" or "Reviewed-by" should be used instead. > > Understood. =A0This driver has passed through my hands (and in front of > my eyes) in various forms many times in its development, so I figured > an s-o-b was appropriate. > > That being said, for this particular version, and ack is probably more > appropriate. > > Sandeep, after you refresh, please add > > Acked-by: Kevin Hilman I've already picked it up, no need for the refresh. Some notes: It looks like the contents of the .h file is entirely driver private stuff. I only want to see .h files when they are needed to export interface information (like platform data), or when a driver needs multiple .c files. Rather than comment and wait for a refresh, I've picked up the patch and moved the .h contents into the .c. If you really do need something in a .h then you can submit a fixup patch to move the parts you need back out. I also fixed up minor mistake in linuxdoc headers (linuxdoc headers start with /** instead of /*). This will be pushed out to my next-spi branch sometime later today. Cheers, g. -- = Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ---------------------------------------------------------------------------= --- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Confere= nce attendees to learn about information security's most important issues throu= gh interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev