Re: [PATCH v2] SPI DaVinci: SPI master driver for DaVinci/DA8xx

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Tue, Jan 5, 2010 at 5:46 PM, Kevin Hilman
<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org> wrote:
> Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> writes:
>
>> On Tue, Jan 5, 2010 at 4:46 PM, Kevin Hilman
>> <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org> wrote:
>>> s-paulraj-l0cyMroinI0@public.gmane.org writes:
>>>
>>>> From: Sandeep Paulraj <s-paulraj-l0cyMroinI0@public.gmane.org>
>>>>
>>>> This patch adds support for a SPI master driver for the
>>>> DaVinci series of SOCs
>>>>
>>>> Signed-off-by: Sandeep Paulraj <s-paulraj-l0cyMroinI0@public.gmane.org>
>>>> Signed-off-by: Mark A. Greer <mgreer-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
>>>> Signed-off-by: Philby John <pjohn-k0rHJ+Hhz/SB+jHODAdFcQ@public.gmane.org>
>>>> Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj-l0cyMroinI0@public.gmane.org>
>>>
>>> Sandeep,
>>>
>>> This needs a minor refresh against current Linus tree for the Makefile
>>> change.
>>>
>>> While doing the Makefile addition, it looks like the list is maintained in
>>> alphabetical order.  Please add davinci in the right order, and feel free to
>>> add my signoff.
>>
>> Signed-of-by lines are only for patches that actually pass through
>> your hands (ie. you add it yourself when you pick it up and pass it).
>> It is not appropriate to add a s-o-b line for someone else.
>> "Acked-by" or "Reviewed-by" should be used instead.
>
> Understood.  This driver has passed through my hands (and in front of
> my eyes) in various forms many times in its development, so I figured
> an s-o-b was appropriate.
>
> That being said, for this particular version, and ack is probably more
> appropriate.
>
> Sandeep, after you refresh, please add
>
> Acked-by: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>

If it has been through your hands in some form, then yes a s-o-b is
appropriate.  I'll take care of it.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev