Re: [PATCH] dw_spi.c can now be built as a module.

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Thu, Jan 21, 2010 at 9:44 AM, Jean-Hugues Deschenes
<jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org> wrote:
> dw_spi.c can now be built as a module.
>
> Signed-off-by: Jean-Hugues Deschenes <jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>

I've picked this up, but....

> diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
> index 4b5a9a1..754f21c 100644
> --- a/drivers/spi/dw_spi.c
> +++ b/drivers/spi/dw_spi.c
> @@ -940,6 +940,17 @@ int dw_spi_resume_host(struct dw_spi *dws)
>  }
>  EXPORT_SYMBOL(dw_spi_resume_host);
>
> +static int __init dw_spi_init(void)
> +{
> +       return 0;
> +}
> +module_init(dw_spi_init);
> +
> +static void __exit dw_spi_exit(void)
> +{
> +}
> +module_exit(dw_spi_exit);

Modules are not required to have module_init() and module_exit()
hooks.  I've dropped this chunk.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev