From: Takashi Iwai <tiwai@suse.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
"Len Brown" <lenb@kernel.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
linux-spi@vger.kernel.org, acpi4asus-user@lists.sourceforge.net,
linux-hwmon@vger.kernel.org, amd-gfx@lists.freedesktop.org,
alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH] ACPI: Test for ACPI_SUCCESS rather than !ACPI_FAILURE
Date: Wed, 27 Jan 2021 07:50:55 +0100 [thread overview]
Message-ID: <s5hk0ryzxdc.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210126202317.2914080-1-helgaas@kernel.org>
On Tue, 26 Jan 2021 21:23:17 +0100,
Bjorn Helgaas wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> The double negative makes it hard to read "if (!ACPI_FAILURE(status))".
> Replace it with "if (ACPI_SUCCESS(status))".
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>
> This isn't really an ACPI patch, but I'm sending it to you, Rafael, since
> it seems easier to just apply these all at once. But I'd be happy to split
> them up into individual patches if you'd rather.
>
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 4 ++--
> drivers/gpu/drm/radeon/radeon_bios.c | 4 ++--
> drivers/hwmon/acpi_power_meter.c | 4 ++--
> drivers/platform/x86/asus-laptop.c | 6 +++---
> drivers/spi/spi.c | 2 +-
> sound/pci/hda/hda_intel.c | 4 ++--
For the sound/*:
Acked-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
next prev parent reply other threads:[~2021-01-27 6:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 20:23 [PATCH] ACPI: Test for ACPI_SUCCESS rather than !ACPI_FAILURE Bjorn Helgaas
2021-01-27 2:17 ` Guenter Roeck
2021-01-27 4:46 ` Deucher, Alexander
2021-01-27 6:50 ` Takashi Iwai [this message]
2021-01-27 11:28 ` Mark Brown
2021-01-27 15:14 ` Bjorn Helgaas
2021-01-27 15:44 ` Rafael J. Wysocki
2021-01-27 16:06 ` Bjorn Helgaas
2021-01-27 17:44 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk0ryzxdc.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=alexander.deucher@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=christian.koenig@amd.com \
--cc=corentin.chary@gmail.com \
--cc=helgaas@kernel.org \
--cc=jdelvare@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=perex@perex.cz \
--cc=rjw@rjwysocki.net \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).