Re: [PATCH 0/5] staging: comedi: tests: Fix various issues

[Ian Abbott <abbotti@mev.co.uk>]

On 14/04/2021 11:09, Dan Carpenter wrote:
> Small resource leaks:
> drivers/staging/comedi/drivers/ii_pci20kc.c:503 ii20k_attach() warn: 'dev->mmio' not released on lines: 452,457,465,474,483.
> drivers/staging/comedi/drivers/ii_pci20kc.c:503 ii20k_attach() warn: 'membase' not released on lines: 441,452,457,465,474,483.

The comedi core calls the driver's "detach" handler if the "attach" or 
"auto_attach" handler returns an error, so those resources will be freed 
in ii20k_detach().

> drivers/staging/comedi/drivers/gsc_hpdi.c:672 gsc_hpdi_auto_attach() warn: 'pcidev->irq' not released on lines: 629,641,646,651,655.

Similarly, gsc_hpdi_detach() will clean up when gsc_hpdi_auto_attach() 
returns an error.

> drivers/staging/comedi/drivers/addi_apci_2032.c:289 apci2032_auto_attach() warn: 'pcidev->irq' not released on lines: 279.

apci2032_detach() is called to clean up when apci2032_auto_attach() 
returns an error.  The IRQ is released by the call to comedi_pci_detach().

> drivers/staging/comedi/drivers/cb_pcidas.c:1446 cb_pcidas_auto_attach() warn: 'pcidev->irq' not released on lines: 1295,1301,1305,1340,1358,1378,1409,1427.

cb_pcidas_detach() is called to clean up when cb_pcidas_auto_attach() 
returns an error.  Some of the clean-up occurs in the call to 
comedi_pci_detach().

> drivers/staging/comedi/drivers/cb_pcidas64.c:4046 auto_attach() warn: 'pcidev->irq' not released on lines: 4044.

detach() is called to clean up when auto_attach() returns an error.

> regards,
> dan carpenter

Thanks.  I'll take a look at the other stuff you mentioned.

Regards,
Ian Abbott

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-