From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones
Date: Mon, 10 May 2021 15:53:38 +0200 [thread overview]
Message-ID: <20210510135338.GC4434@agape.jhs> (raw)
In-Reply-To: <29938747c82e4cf1837be5f1cdb803b7@AcuMS.aculab.com>
Hello David,
On Mon, May 10, 2021 at 01:38:49PM +0000, David Laight wrote:
> > replace private CRC-32 routines with in-kernel ones.
>
> Have you verified that they compute the same CRC?
thank you, I forgot to write in the cover letter that
it is not tested. I don't know how could I test it without
having the hardware...
Maybe is it reliable enough writing a small standalone program
using both procedures and compare the results?
>
> There are all sorts of subtle reasons why the outputs can differ.
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>
thank you,
fabio
next prev parent reply other threads:[~2021-05-10 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 13:19 [PATCH v2 0/2] staging: rtl8723bs: use of generic CRC-32 Fabio Aiuto
2021-05-10 13:19 ` [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones Fabio Aiuto
2021-05-10 13:38 ` David Laight
2021-05-10 13:53 ` Fabio Aiuto [this message]
2021-05-11 9:49 ` Fabio Aiuto
2021-05-10 13:19 ` [PATCH v2 2/2] staging: rtl8723bs: remove unneeded comments to silence 'line too long' warning Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510135338.GC4434@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).