From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 216D872 for ; Wed, 9 Jun 2021 10:37:22 +0000 (UTC) Received: by mail-ot1-f53.google.com with SMTP id i12-20020a05683033ecb02903346fa0f74dso23417261otu.10 for ; Wed, 09 Jun 2021 03:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wLl8pnET+SDuIlIX2Nbz/uqjI22Y9csWS/tvxvAKpbc=; b=OThcgThq2MUjHm67XXXHvXuifR9Ue+5Xr9gP65gN41vI6ZZJ6GPdFe+lKjzeSa32N1 9rRwjCg+xumUp2D+tWI0iph0BZkPv7MPiUdAOHb/oopBpJs16ika10Ik24iBCq6yPMog GkiDI/+nrKE40Qh99ZxedgT9x8mv3Jr62ZUBhWiQKcIbUqbGnMnSsJNKVGdnoCvHV4TE s63wNmNYRzaqU3Leyy2GJnmXVBkDS+e0UQHuRas83tVIEc8UBCFbOvSdt/2BGWAMkBxX 0CArtJXFIpbjgkYMVmiE+1nm+Pt9XB/kaAGEzZZ73MIvgH3I6OKdsX1dfZQJxMtf9u74 GYiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=wLl8pnET+SDuIlIX2Nbz/uqjI22Y9csWS/tvxvAKpbc=; b=TpuN9gaMkQMyZLV7eM7zz6Uj83X5vYIMjHitPKoBmHbhC+JqsrS1RR8nrMtTg4MIkN uXssloJZS1t9ZYSb5J62vCPxtA2/LntWpqsnBqHZzDbgSnm4fwWP4LVuu/VID6JjL/08 iYOt79WipJZJmz2+Ef/dIM0M67PQGaZc5e9Yxiskbv4WnvjpU2O3XFaZ4zDoiF9/90lN jwai7KItewKSV+mf2bmhAJVUiz5AGBLUzPm8/DzBEpwQ/Fw8jmNSph4go09RTJcp2Y+b pUOa4xiK1fuqc263eED6PjcGJGPFG7yw5zWdHeNt2c+d5+kDRWXakKOQbLgPKM2LZAfe 6umA== X-Gm-Message-State: AOAM5332oLCkIeHwgtOvEReLCGBjQrFmruULeDMA3ZwPP0bhL0erKmPz imw8QQ9ATVh++g4MQqX6b8Q= X-Google-Smtp-Source: ABdhPJytNIJgphMD7MwvKNhQbCtHJ5uuW6MpRZI6XhC9TgdnUdpZYwrIPXPhhiBz2a1TsJll7WBE4g== X-Received: by 2002:a05:6830:18c2:: with SMTP id v2mr11462055ote.153.1623235041442; Wed, 09 Jun 2021 03:37:21 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id w20sm2047489otl.51.2021.06.09.03.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 03:37:21 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 9 Jun 2021 03:37:19 -0700 From: Guenter Roeck To: Dan Carpenter Cc: Larry Finger , Greg Kroah-Hartman , Martin Kaiser , Ivan Safonov , Simon Fong , Michael Straube , linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 5/7] staging: rtl8188eu: use safe iterator in xmit_delivery_enabled_frames() Message-ID: <20210609103719.GE3727184@roeck-us.net> References: X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 07, 2021 at 09:18:13PM +0300, Dan Carpenter wrote: > This loop calls list_del_init(&pxmitframe->list) and "pxmitframe" is the > list iterator so it leads to a forever loop. We need to use a _safe() > iterator to fix this. > > Fixes: 23017c8842d2 ("staging: rtl8188eu: Use list iterators and helpers") > Signed-off-by: Dan Carpenter Reviewed-by: Guenter Roeck > --- > drivers/staging/rtl8188eu/core/rtw_xmit.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c > index d5489811c5bc..718dd20ff36c 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c > +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c > @@ -1912,17 +1912,14 @@ void wakeup_sta_to_xmit(struct adapter *padapter, struct sta_info *psta) > void xmit_delivery_enabled_frames(struct adapter *padapter, struct sta_info *psta) > { > u8 wmmps_ac = 0; > - struct list_head *xmitframe_plist, *xmitframe_phead; > - struct xmit_frame *pxmitframe = NULL; > + struct list_head *xmitframe_phead; > + struct xmit_frame *pxmitframe, *n; > struct sta_priv *pstapriv = &padapter->stapriv; > > spin_lock_bh(&psta->sleep_q.lock); > > xmitframe_phead = get_list_head(&psta->sleep_q); > - list_for_each(xmitframe_plist, xmitframe_phead) { > - pxmitframe = list_entry(xmitframe_plist, struct xmit_frame, > - list); > - > + list_for_each_entry_safe(pxmitframe, n, xmitframe_phead, list) { > switch (pxmitframe->attrib.priority) { > case 1: > case 2: > -- > 2.30.2 >