linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH -next resend] media: staging: media: atomisp: pci: fix error return code in atomisp_pci_probe()
@ 2021-06-17 13:55 Yang Yingliang
  2021-06-17 13:58 ` Dan Carpenter
  0 siblings, 1 reply; 3+ messages in thread
From: Yang Yingliang @ 2021-06-17 13:55 UTC (permalink / raw)
  To: linux-kernel, linux-staging, linux-media
  Cc: mchehab, sakari.ailus, dan.carpenter

If init_atomisp_wdts() fails, atomisp_pci_probe() need return
error code.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
index 948769ca6539..d50c38e1cd1d 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
@@ -1763,7 +1763,8 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
 	if (err < 0)
 		goto register_entities_fail;
 	/* init atomisp wdts */
-	if (init_atomisp_wdts(isp) != 0)
+	err = init_atomisp_wdts(isp);
+	if (err)
 		goto wdt_work_queue_fail;
 
 	/* save the iunit context only once after all the values are init'ed. */
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-17 14:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 13:55 [PATCH -next resend] media: staging: media: atomisp: pci: fix error return code in atomisp_pci_probe() Yang Yingliang
2021-06-17 13:58 ` Dan Carpenter
2021-06-17 14:06   ` Yang Yingliang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).