* [PATCH] staging: rtl8188eu: remove useless comment
@ 2021-06-19 17:50 Michael Straube
2021-06-20 13:31 ` Martin Kaiser
0 siblings, 1 reply; 2+ messages in thread
From: Michael Straube @ 2021-06-19 17:50 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, martin, phil, linux-staging, linux-kernel, Michael Straube
Remove block comment about function HwSuspendModeEnable92Cu.
The comment contains no useful information and there is even
no HwSuspendModeEnable92Cu function in the driver code.
'git grep -n HwSuspendModeEnable92Cu drivers/staging/rtl8188eu'
returns nothing.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index dcdf868b394d..6c88675ae251 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -601,22 +601,6 @@ static void _InitAntenna_Selection(struct adapter *Adapter)
haldata->CurAntenna = Antenna_B;
}
-/*-----------------------------------------------------------------------------
- * Function: HwSuspendModeEnable92Cu()
- *
- * Overview: HW suspend mode switch.
- *
- * Input: NONE
- *
- * Output: NONE
- *
- * Return: NONE
- *
- * Revised History:
- * When Who Remark
- * 08/23/2010 MHC HW suspend mode switch test..
- *---------------------------------------------------------------------------
- */
enum rt_rf_power_state RfOnOffDetect(struct adapter *adapt)
{
u8 val8;
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8188eu: remove useless comment
2021-06-19 17:50 [PATCH] staging: rtl8188eu: remove useless comment Michael Straube
@ 2021-06-20 13:31 ` Martin Kaiser
0 siblings, 0 replies; 2+ messages in thread
From: Martin Kaiser @ 2021-06-20 13:31 UTC (permalink / raw)
To: Michael Straube; +Cc: gregkh, Larry.Finger, phil, linux-staging, linux-kernel
Thus wrote Michael Straube (straube.linux@gmail.com):
> Remove block comment about function HwSuspendModeEnable92Cu.
> The comment contains no useful information and there is even
> no HwSuspendModeEnable92Cu function in the driver code.
> 'git grep -n HwSuspendModeEnable92Cu drivers/staging/rtl8188eu'
> returns nothing.
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
> drivers/staging/rtl8188eu/hal/usb_halinit.c | 16 ----------------
> 1 file changed, 16 deletions(-)
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> index dcdf868b394d..6c88675ae251 100644
> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> @@ -601,22 +601,6 @@ static void _InitAntenna_Selection(struct adapter *Adapter)
> haldata->CurAntenna = Antenna_B;
> }
> -/*-----------------------------------------------------------------------------
> - * Function: HwSuspendModeEnable92Cu()
> - *
> - * Overview: HW suspend mode switch.
> - *
> - * Input: NONE
> - *
> - * Output: NONE
> - *
> - * Return: NONE
> - *
> - * Revised History:
> - * When Who Remark
> - * 08/23/2010 MHC HW suspend mode switch test..
> - *---------------------------------------------------------------------------
> - */
> enum rt_rf_power_state RfOnOffDetect(struct adapter *adapt)
> {
> u8 val8;
> --
> 2.32.0
You're right. The function for this comment is already gone.
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-20 13:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-19 17:50 [PATCH] staging: rtl8188eu: remove useless comment Michael Straube
2021-06-20 13:31 ` Martin Kaiser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).