linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/18] staging: rtl8723bs: remove register initializations tied to 802.11ac standard
Date: Mon, 21 Jun 2021 14:45:04 +0200	[thread overview]
Message-ID: <20210621124503.GC1408@agape.jhs> (raw)
In-Reply-To: <b3f7e373-a7f9-f48f-b510-7eb3e56e872e@redhat.com>

Hello Hans,

On Mon, Jun 21, 2021 at 11:48:27AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 6/19/21 12:47 PM, Fabio Aiuto wrote:
> > remove register initializations tied to 802.11ac standard which
> > is not supported by the device.
> > 
> > It's a dangerous operation, relying only on comments, but tested
> > on a Lenovo Ideapad MIIX 300-10IBY tablet seems to work.
> > 
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> 
> TBH I think this patch should be dropped from the series, you
> are dropping a bunch of register writes which likely are actually
> doing something, so this is not just dead code removal.
> 
> Regards,
> 
> Hans
> 
> 
> > ---
> >  drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 ------------
> >  1 file changed, 12 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> > index 059d3050acc6..3a03dfb8d275 100644
> > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> > @@ -1718,24 +1718,12 @@ void _InitBurstPktLen_8723BS(struct adapter *Adapter)
> >  	struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
> >  
> >  	rtw_write8(Adapter, 0x4c7, rtw_read8(Adapter, 0x4c7)|BIT(7)); /* enable single pkt ampdu */
> > -	rtw_write8(Adapter, REG_RX_PKT_LIMIT_8723B, 0x18);		/* for VHT packet length 11K */
> >  	rtw_write8(Adapter, REG_MAX_AGGR_NUM_8723B, 0x1F);
> >  	rtw_write8(Adapter, REG_PIFS_8723B, 0x00);
> >  	rtw_write8(Adapter, REG_FWHW_TXQ_CTRL_8723B, rtw_read8(Adapter, REG_FWHW_TXQ_CTRL)&(~BIT(7)));
> >  	if (pHalData->AMPDUBurstMode)
> >  		rtw_write8(Adapter, REG_AMPDU_BURST_MODE_8723B,  0x5F);
> >  	rtw_write8(Adapter, REG_AMPDU_MAX_TIME_8723B, 0x70);
> > -
> > -	/*  ARFB table 9 for 11ac 5G 2SS */
> > -	rtw_write32(Adapter, REG_ARFR0_8723B, 0x00000010);
> > -	if (IS_NORMAL_CHIP(pHalData->VersionID))
> > -		rtw_write32(Adapter, REG_ARFR0_8723B+4, 0xfffff000);
> > -	else
> > -		rtw_write32(Adapter, REG_ARFR0_8723B+4, 0x3e0ff000);
> > -
> > -	/*  ARFB table 10 for 11ac 5G 1SS */
> > -	rtw_write32(Adapter, REG_ARFR1_8723B, 0x00000010);
> > -	rtw_write32(Adapter, REG_ARFR1_8723B+4, 0x003ff000);
> >  }
> >  
> >  static void ResumeTxBeacon(struct adapter *padapter)
> > 
> 

ok, I will drop it in next v2.

Thank you for review,

fabio

  reply	other threads:[~2021-06-21 12:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-19 10:47 [PATCH 00/18] staging: rtl8723bs: remove 5Ghz code Fabio Aiuto
2021-06-19 10:47 ` [PATCH 01/18] staging: rtl8723bs: remove all 5Ghz network types Fabio Aiuto
2021-06-21  9:40   ` Hans de Goede
2021-06-21 11:23     ` Fabio Aiuto
2021-06-19 10:47 ` [PATCH 02/18] staging: rtl8723bs: remove code related to unsupported channel bandwidth Fabio Aiuto
2021-06-19 10:47 ` [PATCH 03/18] staging: rtl8723bs: remove unused enum items related to channel bonding Fabio Aiuto
2021-06-19 10:47 ` [PATCH 04/18] staging: rtl8723bs: rename " Fabio Aiuto
2021-06-19 10:47 ` [PATCH 05/18] staging: rtl8723bs: remove 5Ghz field in struct registry_priv Fabio Aiuto
2021-06-19 10:47 ` [PATCH 06/18] staging: rtl8723bs: remove struct rt_channel_plan_5g Fabio Aiuto
2021-06-19 10:47 ` [PATCH 07/18] staging: rtl8723bs: remove all branchings between 2.4Ghz and 5Ghz band types Fabio Aiuto
2021-06-19 10:47 ` [PATCH 08/18] staging: rtl8723bs: beautify prototypes in include/hal_com_phycfg.h Fabio Aiuto
2021-06-19 10:47 ` [PATCH 09/18] staging: rtl8723bs: remove 5Ghz code related to channel plan definition Fabio Aiuto
2021-06-19 10:47 ` [PATCH 10/18] staging: rtl8723bs: remove some unused 5Ghz macro definitions Fabio Aiuto
2021-06-19 10:47 ` [PATCH 11/18] staging: rtl8723bs: remove 5Ghz code related to RF power calibration Fabio Aiuto
2021-06-19 10:47 ` [PATCH 12/18] staging: rtl8723bs: remove VHT dead code Fabio Aiuto
2021-06-21  9:45   ` Hans de Goede
2021-06-21 12:41     ` Fabio Aiuto
2021-06-21 12:45       ` Hans de Goede
2021-06-21 12:51         ` Fabio Aiuto
2021-06-22  9:16     ` Fabio Aiuto
2021-06-22  9:19       ` Hans de Goede
2021-06-22  9:57         ` Fabio Aiuto
2021-06-22 11:15           ` Hans de Goede
2021-06-19 10:47 ` [PATCH 13/18] staging: rtl8723bs: remove unused ODM_CMNINFO_BOARD_TYPE enum item Fabio Aiuto
2021-06-19 10:47 ` [PATCH 14/18] staging: rtl8723bs: fix macro value for 2.4Ghz only device Fabio Aiuto
2021-06-19 10:47 ` [PATCH 15/18] staging: rtl8723bs: remove register initializations tied to 802.11ac standard Fabio Aiuto
2021-06-21  9:48   ` Hans de Goede
2021-06-21 12:45     ` Fabio Aiuto [this message]
2021-06-19 10:47 ` [PATCH 16/18] staging: rtl8723bs: remove obsolete 5Ghz comments Fabio Aiuto
2021-06-19 10:47 ` [PATCH 17/18] staging: rtl8723bs: fix check allowing 5Ghz settings Fabio Aiuto
2021-06-19 10:47 ` [PATCH 18/18] staging: rtl8723bs: remove item from TODO list Fabio Aiuto
2021-06-21  9:49 ` [PATCH 00/18] staging: rtl8723bs: remove 5Ghz code Hans de Goede
2021-06-21 12:47   ` Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210621124503.GC1408@agape.jhs \
    --to=fabioaiuto83@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).