From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8194671 for ; Mon, 21 Jun 2021 12:45:08 +0000 (UTC) Received: by mail-wr1-f48.google.com with SMTP id n7so19523058wri.3 for ; Mon, 21 Jun 2021 05:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ewxjlfESBtSi0zj0qL9WBWTJ6mflD9jX2jhFXxxGDxE=; b=GGIJRfHU2Ka8BTGXzTSWkOYdIgTTn0TPWYYDyEn0LxhipvhWmZEUBzYdo7/tZRR6w5 NzU2uKsGyWQxa4T81ehHcK/yvQX0z9Gf1mPDj+YtbAhiP0YmYTj9OSeVyV5bO5hH61JB UyetaLApi/xtcvzVNYglA2cxjVNcURUVTrrJqTT6zDI938NE4i6y1tsaYVgQGMYLR61g aqchbG3Lmddh5t2RCPblf655AyGKMfTMNTJ+VwtBEbQf9BZKio8Vrw4BQo7Qgj1/ughH xFGExKnn9KUvJR1h8L613rXyTX057R7VAnSU25cEJvAJWZFlJToF8ofKI2WAA0CsfFZg mJzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ewxjlfESBtSi0zj0qL9WBWTJ6mflD9jX2jhFXxxGDxE=; b=Fjz9uWrQVoBttRNa4uHeUqyu2SnPCfMBKodKsks/iDHpVd515V1VYzTPFfHAaOi9wH d4xLPs8ZjP8MiBTXPFfrw7dSF6jka8yihrRrgeBLePnHSKdj1T0TdsdJKycuFH+rzRbl JaxzfItpU4oQkzi8zxBLDeoM+6klDp48B2Y8kiL5ItCcl39P9mdPXEunK3EmngKt89t6 OZMO87I1r+mPdQhsgQcx6zOStOFOFZwqxAQ40R+iHUTS5C/c4K85C84wvCeMTBImKffW 2OH9fkbMEMeYwub3ofOVTKM92IVG7sY/OiueD+uK5kEUQ+fkI1e3gKZmx8TDgDmiS32I lZNA== X-Gm-Message-State: AOAM530DJN5xa2Jds5/dpLkn82A5HDHQEOuNkC7jeh9VrcZFbIOHYsTv n0mr2QNQCxXiFZSSxhQyjII= X-Google-Smtp-Source: ABdhPJwbdxyhQW8H+YFfffLHtIRfwu5zQBJgjVNwDMEb1PF/RxRVybx/RLeO+vcsyOQZh3CFR5PwPA== X-Received: by 2002:adf:f088:: with SMTP id n8mr18186291wro.227.1624279507016; Mon, 21 Jun 2021 05:45:07 -0700 (PDT) Received: from agape.jhs ([5.171.73.54]) by smtp.gmail.com with ESMTPSA id l16sm20214092wmj.47.2021.06.21.05.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 05:45:06 -0700 (PDT) Date: Mon, 21 Jun 2021 14:45:04 +0200 From: Fabio Aiuto To: Hans de Goede Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/18] staging: rtl8723bs: remove register initializations tied to 802.11ac standard Message-ID: <20210621124503.GC1408@agape.jhs> References: <66706b5cb6474c4482c3342c4383fe62eba54967.1624099126.git.fabioaiuto83@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Hello Hans, On Mon, Jun 21, 2021 at 11:48:27AM +0200, Hans de Goede wrote: > Hi, > > On 6/19/21 12:47 PM, Fabio Aiuto wrote: > > remove register initializations tied to 802.11ac standard which > > is not supported by the device. > > > > It's a dangerous operation, relying only on comments, but tested > > on a Lenovo Ideapad MIIX 300-10IBY tablet seems to work. > > > > Signed-off-by: Fabio Aiuto > > TBH I think this patch should be dropped from the series, you > are dropping a bunch of register writes which likely are actually > doing something, so this is not just dead code removal. > > Regards, > > Hans > > > > --- > > drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 ------------ > > 1 file changed, 12 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c > > index 059d3050acc6..3a03dfb8d275 100644 > > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c > > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c > > @@ -1718,24 +1718,12 @@ void _InitBurstPktLen_8723BS(struct adapter *Adapter) > > struct hal_com_data *pHalData = GET_HAL_DATA(Adapter); > > > > rtw_write8(Adapter, 0x4c7, rtw_read8(Adapter, 0x4c7)|BIT(7)); /* enable single pkt ampdu */ > > - rtw_write8(Adapter, REG_RX_PKT_LIMIT_8723B, 0x18); /* for VHT packet length 11K */ > > rtw_write8(Adapter, REG_MAX_AGGR_NUM_8723B, 0x1F); > > rtw_write8(Adapter, REG_PIFS_8723B, 0x00); > > rtw_write8(Adapter, REG_FWHW_TXQ_CTRL_8723B, rtw_read8(Adapter, REG_FWHW_TXQ_CTRL)&(~BIT(7))); > > if (pHalData->AMPDUBurstMode) > > rtw_write8(Adapter, REG_AMPDU_BURST_MODE_8723B, 0x5F); > > rtw_write8(Adapter, REG_AMPDU_MAX_TIME_8723B, 0x70); > > - > > - /* ARFB table 9 for 11ac 5G 2SS */ > > - rtw_write32(Adapter, REG_ARFR0_8723B, 0x00000010); > > - if (IS_NORMAL_CHIP(pHalData->VersionID)) > > - rtw_write32(Adapter, REG_ARFR0_8723B+4, 0xfffff000); > > - else > > - rtw_write32(Adapter, REG_ARFR0_8723B+4, 0x3e0ff000); > > - > > - /* ARFB table 10 for 11ac 5G 1SS */ > > - rtw_write32(Adapter, REG_ARFR1_8723B, 0x00000010); > > - rtw_write32(Adapter, REG_ARFR1_8723B+4, 0x003ff000); > > } > > > > static void ResumeTxBeacon(struct adapter *padapter) > > > ok, I will drop it in next v2. Thank you for review, fabio