From: Dan Carpenter <dan.carpenter@oracle.com>
To: Coiby Xu <coiby.xu@gmail.com>
Cc: linux-staging@lists.linux.dev, netdev@vger.kernel.org,
Benjamin Poirier <benjamin.poirier@gmail.com>,
Shung-Hsi Yu <shung-hsi.yu@suse.com>,
Manish Chopra <manishc@marvell.com>,
"supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER"
<GR-Linux-NIC-Dev@marvell.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:CLANG/LLVM BUILD SUPPORT"
<clang-built-linux@googlegroups.com>
Subject: Re: [RFC 17/19] staging: qlge: fix weird line wrapping
Date: Tue, 22 Jun 2021 11:46:11 +0300 [thread overview]
Message-ID: <20210622084611.GM1861@kadam> (raw)
In-Reply-To: <20210621134902.83587-18-coiby.xu@gmail.com>
On Mon, Jun 21, 2021 at 09:49:00PM +0800, Coiby Xu wrote:
> @@ -524,8 +523,8 @@ static int qlge_set_routing_reg(struct qlge_adapter *qdev, u32 index, u32 mask,
> {
> value = RT_IDX_DST_DFLT_Q | /* dest */
> RT_IDX_TYPE_NICQ | /* type */
> - (RT_IDX_IP_CSUM_ERR_SLOT <<
> - RT_IDX_IDX_SHIFT); /* index */
> + (RT_IDX_IP_CSUM_ERR_SLOT
> + << RT_IDX_IDX_SHIFT); /* index */
The original is not great but the new indenting is definitely worse.
It might look nicer with the comments moved in the front? Why does
RT_IDX_IDX_SHIFT have two IDX strings?
/* value = dest | type | index; */
value = RT_IDX_DST_DFLT_Q |
RT_IDX_TYPE_NICQ |
(RT_IDX_IP_CSUM_ERR_SLOT << RT_IDX_IDX_SHIFT);
> break;
> }
> case RT_IDX_TU_CSUM_ERR: /* Pass up TCP/UDP CSUM error frames. */
> @@ -554,7 +553,8 @@ static int qlge_set_routing_reg(struct qlge_adapter *qdev, u32 index, u32 mask,
> {
> value = RT_IDX_DST_DFLT_Q | /* dest */
> RT_IDX_TYPE_NICQ | /* type */
> - (RT_IDX_MCAST_MATCH_SLOT << RT_IDX_IDX_SHIFT);/* index */
> + (RT_IDX_MCAST_MATCH_SLOT
> + << RT_IDX_IDX_SHIFT); /* index */
Original is better.
> break;
> }
> case RT_IDX_RSS_MATCH: /* Pass up matched RSS frames. */
> @@ -648,15 +648,15 @@ static int qlge_read_flash_word(struct qlge_adapter *qdev, int offset, __le32 *d
> {
> int status = 0;
> /* wait for reg to come ready */
> - status = qlge_wait_reg_rdy(qdev,
> - FLASH_ADDR, FLASH_ADDR_RDY, FLASH_ADDR_ERR);
> + status = qlge_wait_reg_rdy(qdev, FLASH_ADDR, FLASH_ADDR_RDY,
> + FLASH_ADDR_ERR);
> if (status)
> goto exit;
> /* set up for reg read */
> qlge_write32(qdev, FLASH_ADDR, FLASH_ADDR_R | offset);
> /* wait for reg to come ready */
> - status = qlge_wait_reg_rdy(qdev,
> - FLASH_ADDR, FLASH_ADDR_RDY, FLASH_ADDR_ERR);
> + status = qlge_wait_reg_rdy(qdev, FLASH_ADDR, FLASH_ADDR_RDY,
> + FLASH_ADDR_ERR);
> if (status)
> goto exit;
> /* This data is stored on flash as an array of
> @@ -792,8 +792,8 @@ static int qlge_write_xgmac_reg(struct qlge_adapter *qdev, u32 reg, u32 data)
> {
> int status;
> /* wait for reg to come ready */
> - status = qlge_wait_reg_rdy(qdev,
> - XGMAC_ADDR, XGMAC_ADDR_RDY, XGMAC_ADDR_XME);
> + status = qlge_wait_reg_rdy(qdev, XGMAC_ADDR, XGMAC_ADDR_RDY,
> + XGMAC_ADDR_XME);
> if (status)
> return status;
> /* write the data to the data reg */
> @@ -811,15 +811,15 @@ int qlge_read_xgmac_reg(struct qlge_adapter *qdev, u32 reg, u32 *data)
> {
> int status = 0;
> /* wait for reg to come ready */
> - status = qlge_wait_reg_rdy(qdev,
> - XGMAC_ADDR, XGMAC_ADDR_RDY, XGMAC_ADDR_XME);
> + status = qlge_wait_reg_rdy(qdev, XGMAC_ADDR, XGMAC_ADDR_RDY,
> + XGMAC_ADDR_XME);
Need a blank line after the declaration block.
> if (status)
> goto exit;
> /* set up for reg read */
> qlge_write32(qdev, XGMAC_ADDR, reg | XGMAC_ADDR_R);
> /* wait for reg to come ready */
> - status = qlge_wait_reg_rdy(qdev,
> - XGMAC_ADDR, XGMAC_ADDR_RDY, XGMAC_ADDR_XME);
> + status = qlge_wait_reg_rdy(qdev, XGMAC_ADDR, XGMAC_ADDR_RDY,
> + XGMAC_ADDR_XME);
> if (status)
> goto exit;
> /* get the data */
regards,
dan carpenter
next prev parent reply other threads:[~2021-06-22 8:46 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 13:48 [RFC 00/19] Improve the qlge driver based on drivers/staging/qlge/TODO Coiby Xu
2021-06-21 13:48 ` [RFC 01/19] staging: qlge: fix incorrect truesize accounting Coiby Xu
2021-06-21 14:10 ` Dan Carpenter
2021-06-22 11:36 ` Coiby Xu
2021-06-23 4:55 ` Benjamin Poirier
2021-06-24 11:47 ` Coiby Xu
2021-06-28 0:14 ` Coiby Xu
2021-06-21 13:48 ` [RFC 02/19] staging: qlge: change LARGE_BUFFER_MAX_SIZE to 4096 Coiby Xu
2021-06-21 13:48 ` [RFC 03/19] staging: qlge: alloc skb with only enough room for header when data is put in the fragments Coiby Xu
2021-06-21 13:48 ` [RFC 04/19] staging: qlge: add qlge_* prefix to avoid namespace clashes Coiby Xu
2021-06-22 7:55 ` Benjamin Poirier
2021-06-24 11:34 ` Coiby Xu
2021-06-21 13:48 ` [RFC 05/19] staging: qlge: rename rx to completion queue and seperate rx_ring from completion queue Coiby Xu
2021-06-21 13:48 ` [RFC 06/19] staging: qlge: disable flow control by default Coiby Xu
2021-06-22 7:49 ` Benjamin Poirier
2021-06-24 11:33 ` Coiby Xu
2021-06-21 13:48 ` [RFC 07/19] staging: qlge: remove the TODO item of unnecessary memset 0 Coiby Xu
2021-06-21 13:48 ` [RFC 08/19] staging: qlge: reorder members of qlge_adapter for optimization Coiby Xu
2021-06-21 13:48 ` [RFC 09/19] staging: qlge: remove the TODO item of reorder struct Coiby Xu
2021-06-21 13:48 ` [RFC 10/19] staging: qlge: remove the TODO item of avoid legacy/deprecated apis Coiby Xu
2021-06-21 13:48 ` [RFC 11/19] staging: qlge: the number of pages to contain a buffer queue is constant Coiby Xu
2021-06-21 13:48 ` [RFC 12/19] staging: qlge: rewrite do while loops as for loops in qlge_start_rx_ring Coiby Xu
2021-06-22 7:45 ` Benjamin Poirier
2021-06-24 11:56 ` Coiby Xu
2021-06-21 13:48 ` [RFC 13/19] staging: qlge: rewrite do while loop as for loop in qlge_sem_spinlock Coiby Xu
2021-06-22 7:20 ` Dan Carpenter
2021-06-24 11:22 ` Coiby Xu
2021-06-30 10:58 ` Joe Perches
2021-06-30 23:33 ` Coiby Xu
2021-07-01 4:35 ` Joe Perches
2021-07-02 23:56 ` Coiby Xu
2021-06-21 13:48 ` [RFC 14/19] staging: qlge: rewrite do while loop as for loop in qlge_refill_bq Coiby Xu
2021-06-21 13:48 ` [RFC 15/19] staging: qlge: remove the TODO item about rewriting while loops as simple for loops Coiby Xu
2021-06-21 13:48 ` [RFC 16/19] staging: qlge: remove deadcode in qlge_build_rx_skb Coiby Xu
2021-06-22 7:29 ` Dan Carpenter
2021-06-24 11:25 ` Coiby Xu
2021-06-24 12:49 ` Dan Carpenter
2021-06-27 10:53 ` Coiby Xu
2021-06-28 6:46 ` Dan Carpenter
2021-06-29 13:35 ` Coiby Xu
2021-06-29 14:22 ` Dan Carpenter
2021-06-30 23:19 ` Coiby Xu
2021-06-21 13:49 ` [RFC 17/19] staging: qlge: fix weird line wrapping Coiby Xu
2021-06-22 8:46 ` Dan Carpenter [this message]
2021-06-24 11:55 ` Coiby Xu
2021-06-21 13:49 ` [RFC 18/19] staging: qlge: fix two indentation issues Coiby Xu
2021-06-21 13:49 ` [RFC 19/19] staging: qlge: remove TODO item of unnecessary runtime checks Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622084611.GM1861@kadam \
--to=dan.carpenter@oracle.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=benjamin.poirier@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=coiby.xu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manishc@marvell.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=shung-hsi.yu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).