From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A489670 for ; Tue, 22 Jun 2021 09:58:01 +0000 (UTC) Received: by mail-wr1-f41.google.com with SMTP id j2so12345439wrs.12 for ; Tue, 22 Jun 2021 02:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XGm5a/Fe5N5jRf7hJWwEELPPpr6Kdx/ELnvMfUGOCzM=; b=KnOYTGoqCw3yaoYvo6WJY/UiRv5L8oNDkJMj3qqXhtSJC835E+qd6HXIB3rnAMslG3 FlJpyUZu60Z/+0jhexM/YXJPwtu5aYO7Asi5ExTZnWujKsutCzN15EN3Ore2qHi1b4tx lhGjv/I1H69Vie0p2xnUX+GmE4FqwivQOUxPVX65ZYiQBgMag8JKa9XxdkduVElUYOuV dMumUbCSxr9Nq4IzKk9X8yr0ko06dB52YhTAb7A+t5tMyccXmDsMUlTFDqlOUrSNp3Md 0IptmioZF3w+PnZVEofJLqr1bSiTHTyRx4oOiOyEjJ1tMSUTh4C9JReJiM6m53eU0oRA WdMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XGm5a/Fe5N5jRf7hJWwEELPPpr6Kdx/ELnvMfUGOCzM=; b=O0qsQKftiEn6NzTGXnFHjGx0kJTUuyBnxfR8zaSYiRdmqe/L2TB/VNUyrECyyfFTyr DvUOG8qLkmhA04nUukwkSQDmGCuNRA/735Wlm8fV3OiWEmmxjYouXVGzuc9HCG4w1/1Q j7+aw8LGAdJkgJlVTUh01QG9tN5ScMznBcTK3FwH6vrmJAwQmPKs+MokqPNpuOiP/MBG aMNDDite4vrhOVcEhXWih76jOdnb8qYosFpZwnyeXvqHwuHxbHICQK+yb5qocTyljf/L DmL0DinsVW8aLKZTN3NVT0fFqWPlV+yKIUvSo3kYBVlugK/B11tkRf8uwiTvySXhBs7/ kqTw== X-Gm-Message-State: AOAM533GgwZwtNXQe1L5NfLIGCOcisIF3anoDaljmg0Me4SKvCjjEC2H lmdNk28FgZCETkbiFoi3kyg= X-Google-Smtp-Source: ABdhPJxKxy5rTDAIOoB35xJ/WuhJV0nmoikd+B5VMZ3tQEvzlCfODC2nIz+tWU0Yr5YpQv+yJ34l0A== X-Received: by 2002:a5d:6a8b:: with SMTP id s11mr3645664wru.88.1624355880057; Tue, 22 Jun 2021 02:58:00 -0700 (PDT) Received: from agape.jhs ([5.171.72.34]) by smtp.gmail.com with ESMTPSA id m184sm1875029wmm.26.2021.06.22.02.57.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 02:57:59 -0700 (PDT) Date: Tue, 22 Jun 2021 11:57:57 +0200 From: Fabio Aiuto To: Hans de Goede Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/18] staging: rtl8723bs: remove VHT dead code Message-ID: <20210622095757.GB1426@agape.jhs> References: <20210622091602.GA1426@agape.jhs> <4f128bd2-b84b-132e-c75f-0030701a8a9b@redhat.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f128bd2-b84b-132e-c75f-0030701a8a9b@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) On Tue, Jun 22, 2021 at 11:19:36AM +0200, Hans de Goede wrote: Hi Hans, > Hi Fabio, > > > Moreover I have been quite conservative, for I left untouched HT indexes above > > 7 which rtl8723bs doesn't support. > > > > So IMO I think this patch is fine as is... > >> Perhaps this entire block can never be executed ? > > > > the block is executed but there's no register write happening. Just > > updating of values which will never be fetched. > > Ack, my bad I was under the impression that phy_SetTxPowerByRateBase() > would actually do a register write, but I checked and it just updates > some unused table values, so dropping this code is fine and you can > keep this patch for v2 of the patch set. > > Regards, > > Hans > thank you, what do you think about what I replied about patch 1, shall I remove the '> 14 if block' or leave it as is? Do you think is necessary to keep the conditions inside the block and pack them? I would leave as is but is my opinion... regards, fabio