linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, dan.carpenter@oracle.com,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: [PATCH 3/9] staging: rtl8188eu: remove all DBG_88E_LEVEL calls from core/rtw_ioctl_set.c
Date: Thu, 24 Jun 2021 00:48:56 +0100	[thread overview]
Message-ID: <20210623234902.7411-4-phil@philpotter.co.uk> (raw)
In-Reply-To: <20210623234902.7411-1-phil@philpotter.co.uk>

Remove all DBG_88E_LEVEL calls from core/rtw_ioctl_set.c as this macro is
unnecessary, and these calls are dubious in terms of necessity.
Removing all calls will ultimately allow the removal of the macro
itself.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
---
 drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
index c8b8346adbee..adf772e7bac0 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
@@ -131,8 +131,6 @@ u8 rtw_set_802_11_bssid(struct adapter *padapter, u8 *bssid)
 	u32 cur_time = 0;
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 
-	DBG_88E_LEVEL(_drv_info_, "set bssid:%pM\n", bssid);
-
 	if ((bssid[0] == 0x00 && bssid[1] == 0x00 && bssid[2] == 0x00 &&
 	     bssid[3] == 0x00 && bssid[4] == 0x00 && bssid[5] == 0x00) ||
 	    (bssid[0] == 0xFF && bssid[1] == 0xFF && bssid[2] == 0xFF &&
@@ -214,9 +212,6 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid)
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 	struct wlan_network *pnetwork = &pmlmepriv->cur_network;
 
-	DBG_88E_LEVEL(_drv_info_, "set ssid [%s] fw_state=0x%08x\n",
-		      ssid->ssid, get_fwstate(pmlmepriv));
-
 	if (!padapter->hw_init_completed) {
 		RT_TRACE(_module_rtl871x_ioctl_set_c_, _drv_err_,
 			 ("set_ssid: hw_init_completed == false =>exit!!!\n"));
-- 
2.31.1


  parent reply	other threads:[~2021-06-23 23:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23 23:48 [PATCH 0/9] staging: rtl8188eu: remove DBG_88E_LEVEL and MSG_88E macros Phillip Potter
2021-06-23 23:48 ` [PATCH 1/9] staging: rtl8188eu: remove all DBG_88E_LEVEL calls from os_dep/ioctl_linux.c Phillip Potter
2021-06-23 23:48 ` [PATCH 2/9] staging: rtl8188eu: remove all DBG_88E_LEVEL calls from core/rtw_mlmw_ext.c Phillip Potter
2021-06-23 23:48 ` Phillip Potter [this message]
2021-06-23 23:48 ` [PATCH 4/9] staging: rtl8188eu: remove all DBG_88E_LEVEL calls from core/rtw_pwrctrl.c Phillip Potter
2021-06-23 23:48 ` [PATCH 5/9] staging: rtl8188eu: remove all DBG_88E_LEVEL calls from core/rtw_xmit.c Phillip Potter
2021-06-23 23:48 ` [PATCH 6/9] staging: rtl8188eu: remove DBG_88E_LEVEL macro from include/rtw_debug.h Phillip Potter
2021-06-23 23:49 ` [PATCH 7/9] staging: rtl8188eu: remove MSG_88E call from hal/odm.c Phillip Potter
2021-06-23 23:49 ` [PATCH 8/9] staging: rtl8188eu: remove MSG_88E calls from hal/usb_halinit.c Phillip Potter
2021-06-23 23:49 ` [PATCH 9/9] staging: rtl8188eu: remove MSG_88E macro from include/rtw_debug.h Phillip Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210623234902.7411-4-phil@philpotter.co.uk \
    --to=phil@philpotter.co.uk \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).